From: qianjun.kernel@gmail.com
To: tglx@linutronix.de, peterz@infradead.org, will@kernel.org,
luto@kernel.org
Cc: linux-kernel@vger.kernel.org, shaoyafang@didiglobal.com,
jun qian <qianjun.kernel@gmail.com>
Subject: [RFC PATCH 1/1] Softirq:avoid large sched delay from the pending softirqs
Date: Fri, 17 Jul 2020 02:37:53 -0400 [thread overview]
Message-ID: <1594967873-29522-1-git-send-email-qianjun.kernel@gmail.com> (raw)
From: jun qian <qianjun.kernel@gmail.com>
When get the pending softirqs, it need to process all the pending
softirqs in the while loop. If the processing time of each pending
softirq is need more than 2 msec in this loop, or one of the softirq
will running a long time, according to the original code logic, it
will process all the pending softirqs without wakeuping ksoftirqd,
which will cause a relatively large scheduling delay on the
corresponding CPU, which we do not wish to see. The patch will check
the total time to process pending softirq, if the time exceeds 2 ms
we need to wakeup the ksofirqd to aviod large sched delay.
Signed-off-by: jun qian <qianjun.kernel@gmail.com>
---
kernel/softirq.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/kernel/softirq.c b/kernel/softirq.c
index c4201b7f..602d9fa 100644
--- a/kernel/softirq.c
+++ b/kernel/softirq.c
@@ -299,6 +299,9 @@ asmlinkage __visible void __softirq_entry __do_softirq(void)
}
h++;
pending >>= softirq_bit;
+
+ if (time_after(jiffies, end) && need_resched())
+ break;
}
if (__this_cpu_read(ksoftirqd) == current)
--
1.8.3.1
next reply other threads:[~2020-07-17 6:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-17 6:37 qianjun.kernel [this message]
2020-07-17 22:07 ` [RFC PATCH 1/1] Softirq:avoid large sched delay from the pending softirqs Uladzislau Rezki
2020-07-20 11:33 ` jun qian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1594967873-29522-1-git-send-email-qianjun.kernel@gmail.com \
--to=qianjun.kernel@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=peterz@infradead.org \
--cc=shaoyafang@didiglobal.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox