From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934696AbbI2LK5 (ORCPT ); Tue, 29 Sep 2015 07:10:57 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:50588 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934568AbbI2LKq (ORCPT ); Tue, 29 Sep 2015 07:10:46 -0400 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Peter Griffin , devicetree@vger.kernel.org, vinod.koul@intel.com, srinivas.kandagatla@gmail.com, patrice.chotard@st.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, Ludovic Barre , dmaengine@vger.kernel.org, lee.jones@linaro.org, maxime.coquelin@st.com Subject: Re: [PATCH v2 2/9] dmaengine: st_fdma: Add st fdma platform specific header Date: Tue, 29 Sep 2015 13:10:32 +0200 Message-ID: <1595360.mhtcFfAByg@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20150929092442.GB16955@griffinp-ThinkPad-X1-Carbon-2nd> References: <1441980871-24475-1-git-send-email-peter.griffin@linaro.org> <2654563.3IzPKrUkAU@wuerfel> <20150929092442.GB16955@griffinp-ThinkPad-X1-Carbon-2nd> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:RR9F9cFDIfdmJlRtqbcpko+dT2c7OdVlmD4ee89OzqFCDJAdQS+ kYCUHk49OvMKxX6hK/DLoIkm77R9Gc06+kKfsy+z86OG1Zxg7oBVBEmK5JEXBvMzkOepzxp E9IKTN7Rzt1V450M/t+aU68bCPNiyj14ke7bLxYvWOZylUyfO9xOL7ZTyZaWT1aoNj70z4b tyYlVkwUuZiJ3alp3D2Gg== X-UI-Out-Filterresults: notjunk:1;V01:K0:9GhcUDGgGsU=:HQsp1+tYMzYS/QcUNrXW0Z tS6U4rsRBoyo8p7cp22hWe6yLmRxWOdCFmxldL5Bat23Gx9P/YAg+Jcqdx3q2EXhH6ON9qKX7 RWydqX2dn9AN2xlNTr9KSHcdEmEXdn59X8zapvM3mwLGGzxbTbXoCBNTUlZz2iintqGmu6U78 spapveUWfMnBS2EXapxectJlKKL88fnOMtKehkc1JIMxZ33bfR0B5HTumbu2afv/VaHRG7drT uO0rbOijdTnkf9FiQczFMsznxqb8z8ynvHnjeGoybLrOeeZ1Dpdo8+lQ/h7iJTtek0+fKNFwc tU3VfutfZmbQXidTIgva2wHm+xFlLt8zLOWhVAghpMGmYj8CJ3sZXif4JrTfGXdAO6SeHzHfK BpZjRk1yqtD9652aYmzmqP6QUvKvCc89GC7ga0JoaEm6lLoEeXwTH9M82n088UFmIwe+jeNTO GOImP9NdtN4izaoRSN9BhOV/UyxLLof8BhWIFS/9nPY+mlAD2h0nf9l47hso51Lj0cugdLVAn P2h2cxo1kFSZ6Z9YGTAUtbhKugk8Dyt6QFFGUqnH4+xyUGWcBz3BoP9G/v1gRedN324u4wKKH p8ti50LDF9bO2a3oK+4awo/1KEHyp4y7izwFkg0lK/sZVMosjfCFRC3QFEkqaETj5WlqpqzgU ZVJdtbCneumXe83Me6KgBtyxMdmkGCMMidUKPYR7V2sW9mWqtNQyIDkPP6oXJHmqgcl/LTSr6 qavm7Hkje8h6FTXg Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 29 September 2015 10:24:42 Peter Griffin wrote: > On Fri, 11 Sep 2015, Arnd Bergmann wrote: > > > On Friday 11 September 2015 15:14:24 Peter Griffin wrote: > > > Signed-off-by: Ludovic Barre > > > Signed-off-by: Peter Griffin > > > --- > > > include/linux/platform_data/dma-st_fdma.h | 72 +++++++++++++++++++++++++++++++ > > > 1 file changed, 72 insertions(+) > > > create mode 100644 include/linux/platform_data/dma-st_fdma.h > > > > > > > This clearly needs an explanation of which platforms require the header. > > > > On ARM, all new platforms use DT, so it's obviously not one of them. > > I will move the relevant parts into the st_fdma.h header file, as no other platforms > will be upstreamed that are not DT based. Ok, it's possible that you can simplify the code a bit after you do that, e.g. if you can fold the st_fdma_platform_data structure into the main per-device structure, and if you remove the filter function. Arnd