Re: [v2,3/6] dt-binding: reset-controller: ti: add generic-reset to compatible

Philipp Zabel
2020-08-04T08:15:30Z

On Mon, 2020-08-03 at 14:15 +0800, Crystal Guo wrote:
> The TI syscon reset controller provides a common reset management,
> and should be suitable for other SOCs. Add compatible "generic-reset",
> which denotes to use a common reset-controller driver.
>
> Signed-off-by: Crystal Guo <crystal.guo@mediatek.com>
> ---
> Documentation/devicetree/bindings/reset/ti-syscon-reset.txt | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt b/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt
> index d551161ae785..e36d3631eab2 100644
> --- a/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt
> +++ b/Documentation/devicetree/bindings/reset/ti-syscon-reset.txt
> @@ -25,6 +25,7 @@ Required properties:
> "ti,k2l-pscrst"
> "ti,k2hk-pscrst"
> "ti,syscon-reset"
> + "generic-reset", "ti,syscon-reset"
> - #reset-cells : Should be 1. Please see the reset consumer node below
> for usage details
> - ti,reset-bits : Contains the reset control register information
> --
> 2.18.0

My understanding is that it would be better to add a mtk specific
compatible instead of adding this "generic-reset", especially since we
can't guarantee this binding will be considered generic in the future.
I think there is nothing wrong with specifying
compatible = "mtk,your-compatible", "ti,syscon-reset";
in your device tree if your hardware is indeed compatible with the
specified "ti,syscon-reset" binding, but I may be wrong: Therefore,
please add devicetree@vger.kernel.org to Cc: for binding changes.

regards
Philipp