From: Gurbir Arora <gurbaror@codeaurora.org>
To: linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: bjorn.andersson@linaro.org, mathieu.poirier@linaro.org,
tsoni@codeaurora.org, psodagud@codeaurora.org,
sidgup@codeaurora.org, rishabhb@codeaurora.org,
Gurbir Arora <gurbaror@codeaurora.org>
Subject: [PATCH 1/3] remoteproc: core: Add coredump to remoteproc ops
Date: Fri, 7 Aug 2020 16:31:59 -0700 [thread overview]
Message-ID: <1596843121-82576-2-git-send-email-gurbaror@codeaurora.org> (raw)
In-Reply-To: <1596843121-82576-1-git-send-email-gurbaror@codeaurora.org>
Each remoteproc might have different requirements for coredumps and might
want to choose the type of dumps it wants to collect. This change allows
remoteproc drivers to specify their own custom dump function to be executed
in place of rproc_coredump. If the coredump op is not specified by the
remoteproc driver it will be set to rproc_coredump by default.
Signed-off-by: Rishabh Bhatnagar <rishabhb@codeaurora.org>
Signed-off-by: Siddharth Gupta <sidgup@codeaurora.org>
Signed-off-by: Gurbir Arora <gurbaror@codeaurora.org>
---
drivers/remoteproc/remoteproc_core.c | 6 +++++-
include/linux/remoteproc.h | 1 +
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
index 7f90eee..283ecb6 100644
--- a/drivers/remoteproc/remoteproc_core.c
+++ b/drivers/remoteproc/remoteproc_core.c
@@ -1681,7 +1681,7 @@ int rproc_trigger_recovery(struct rproc *rproc)
goto unlock_mutex;
/* generate coredump */
- rproc_coredump(rproc);
+ rproc->ops->coredump(rproc);
/* load firmware */
ret = request_firmware(&firmware_p, rproc->firmware, dev);
@@ -2113,6 +2113,10 @@ static int rproc_alloc_ops(struct rproc *rproc, const struct rproc_ops *ops)
rproc->ops->sanity_check = rproc_elf_sanity_check;
rproc->ops->get_boot_addr = rproc_elf_get_boot_addr;
+ /* Default to rproc_coredump if no coredump functions is specified */
+ if (!rproc->ops->coredump)
+ rproc->ops->coredump = rproc_coredump;
+
return 0;
}
diff --git a/include/linux/remoteproc.h b/include/linux/remoteproc.h
index 2fa68bf..0ed1a2b 100644
--- a/include/linux/remoteproc.h
+++ b/include/linux/remoteproc.h
@@ -392,6 +392,7 @@ struct rproc_ops {
int (*load)(struct rproc *rproc, const struct firmware *fw);
int (*sanity_check)(struct rproc *rproc, const struct firmware *fw);
u64 (*get_boot_addr)(struct rproc *rproc, const struct firmware *fw);
+ void (*coredump)(struct rproc *rproc);
unsigned long (*panic)(struct rproc *rproc);
};
--
1.9.1
next prev parent reply other threads:[~2020-08-07 23:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-07 23:31 [PATCH 0/3] Introduce mini-dump support for remoteproc Gurbir Arora
2020-08-07 23:31 ` Gurbir Arora [this message]
2020-08-10 22:54 ` [PATCH 1/3] remoteproc: core: Add coredump to remoteproc ops Mathieu Poirier
2020-08-07 23:32 ` [PATCH 2/3] remoteproc: qcom: Add capability to collect minidumps Gurbir Arora
2020-08-08 1:41 ` kernel test robot
2020-08-08 2:09 ` kernel test robot
2020-08-08 2:21 ` kernel test robot
2020-08-07 23:32 ` [PATCH 3/3] remoteproc: qcom: Add minidump id for sm8150 modem remoteproc Gurbir Arora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1596843121-82576-2-git-send-email-gurbaror@codeaurora.org \
--to=gurbaror@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=psodagud@codeaurora.org \
--cc=rishabhb@codeaurora.org \
--cc=sidgup@codeaurora.org \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox