From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932102AbbA2QEL (ORCPT ); Thu, 29 Jan 2015 11:04:11 -0500 Received: from mout.kundenserver.de ([212.227.126.130]:60949 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750840AbbA2QEI (ORCPT ); Thu, 29 Jan 2015 11:04:08 -0500 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Ricardo Ribalda Delgado , Mark Brown , Michal Simek , =?ISO-8859-1?Q?S=F6ren?= Brinkmann , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] spi/xilinx: Cast ioread32/iowrite32 function pointers Date: Thu, 29 Jan 2015 17:04:03 +0100 Message-ID: <1597235.QjzCE74z4V@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1422543073-21895-1-git-send-email-ricardo.ribalda@gmail.com> References: <1422543073-21895-1-git-send-email-ricardo.ribalda@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:H20o7BpHxqNlgKymq7+NOcjPx6nVrsc3lzowjnQCOAzNwgimKJ4 mc5c87tCKnyCuXiK8fDmIvryKPZ5+gTyMDS3Pd+S1XCUJY/kY03AJJp4FlXcOFRuPdHh8Xe pcilLwYhVt+LGlMXWmNxJvGL9rJXFpjLERjFBaUSDSBHORCRAEZqGkgvh/cq1e2UTVKjbmo YdfOtjtA4KuIpm74BXdNw== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 29 January 2015 15:51:13 Ricardo Ribalda Delgado wrote: > * Setup little endian helper functions first and try to use them > * and check if bit was correctly setup or not. > */ > - xspi->read_fn = ioread32; > - xspi->write_fn = iowrite32; > + xspi->read_fn = (u32 (*)(void __iomem *)) ioread32; > + xspi->write_fn = (void (*)(u32, void __iomem *)) iowrite32; > > xspi->write_fn(XSPI_CR_LOOP, xspi->regs + XSPI_CR_OFFSET); > Casting the type of a function you call seems rather dangerous. Why not add an inline function in this driver as a wrapper? Arnd