Re: [PATCH v4 2/2] usb typec: mt6360: Add MT6360 Type-C DT binding documentation

ChiYuan Huang
2020-08-29T00:34:06Z

Rob Herring <robh@kernel.org> 於 2020年8月29日 週六 上午6:06寫道：
>
> On Fri, Aug 28, 2020 at 06:30:36PM +0800, cy_huang wrote:
> > From: ChiYuan Huang <cy_huang@richtek.com>
> >
> > Add a devicetree binding documentation for the MT6360 Type-C driver.
> >
> > usb typec: mt6360: Rename DT binding doument from mt6360 to mt636x
> >
> > Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
> > ---
> > .../bindings/usb/mediatek,mt6360-tcpc.yaml | 73 ++++++++++++++++++++++
> > 1 file changed, 73 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml b/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml
> > new file mode 100644
> > index 00000000..9e8ab0d
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/usb/mediatek,mt6360-tcpc.yaml
> > @@ -0,0 +1,73 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: "http://devicetree.org/schemas/usb/mediatek,mt6360-tcpc.yaml#"
> > +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> > +
> > +title: Mediatek MT6360 Type-C Port Switch and Power Delivery controller DT bindings
> > +
> > +maintainers:
> > + - ChiYuan Huang <cy_huang@richtek.com>
> > +
> > +description: |
> > + Mediatek MT6360 is a multi-functional device. It integrates charger, ADC, flash, RGB indicators,
> > + regulators (BUCKs/LDOs), and TypeC Port Switch with Power Delivery controller.
> > + This document only describes MT6360 Type-C Port Switch and Power Delivery controller.
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - mediatek,mt6360-tcpc
> > +
> > + interrupts-extended:
> > + maxItems: 1
> > +
> > + interrupt-names:
> > + items:
> > + - const: PD_IRQB
> > +
> > +patternProperties:
> > + "connector":
>
> Also, this is not a pattern, so should be under 'properties', and it
> doesn't need quotes.
Will be fixed in next patch.
>
> > + type: object
> > + $ref: ../connector/usb-connector.yaml#
> > + description:
> > + Properties for usb c connector.
> > +
> > +additionalProperties: false
> > +
> > +required:
> > + - compatible
> > + - interrupts-extended
> > + - interrupt-names
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/interrupt-controller/irq.h>
> > + #include <dt-bindings/usb/pd.h>
> > + i2c0 {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + mt6360@34 {
> > + compatible = "mediatek,mt6360";
> > + reg = <0x34>;
> > +
> > + tcpc {
> > + compatible = "mediatek,mt6360-tcpc";
> > + interrupts-extended = <&gpio26 3 IRQ_TYPE_LEVEL_LOW>;
> > + interrupt-names = "PD_IRQB";
> > +
> > + connector {
> > + compatible = "usb-c-connector";
> > + label = "USB-C";
> > + data-role = "dual";
> > + power-role = "dual";
> > + try-power-role = "sink";
> > + source-pdos = <PDO_FIXED(5000, 1000, PDO_FIXED_DUAL_ROLE | PDO_FIXED_DATA_SWAP)>;
> > + sink-pdos = <PDO_FIXED(5000, 2000, PDO_FIXED_DUAL_ROLE | PDO_FIXED_DATA_SWAP)>;
> > + op-sink-microwatt = <10000000>;
> > + };
> > + };
> > + };
> > + };
> > +...
> > --
> > 2.7.4
> >