public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Tyser <ptyser@xes-inc.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Prarit Bhargava <prarit@redhat.com>,
	Lee Jones <lee.jones@linaro.org>,
	linux-kernel@vger.kernel.org,
	Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [PATCH] x86, lpc, Allow only one load of lpc_ich
Date: Wed, 03 Sep 2014 12:29:28 -0500	[thread overview]
Message-ID: <1598720.9R5g9ohVoY@petert> (raw)
In-Reply-To: <20140903155718.GA26776@roeck-us.net>

> > >>> Then why do they [have two devices specified]?
> > >> 
> > >> Because the vendor didn't/forgot to hide one from the kernel in BIOS --
> > >> hence FW_BUG.
> > > 
> > > If only one is useful, why have the second one in the first place?
> > 
> > That's just it -- it shouldn't have been exposed (again, according to
> > Intel).> 
> > > If the devices are present and we can see them, why not have 2?  Some
> > > users might find a use for them.
> > 
> > No one will.
> 
> Really ? I must be the "no one" then.
> 
> If available, I like using two watchdogs: One to be controlled by, say,
> systemd, one to be controlled by the watchdog daemon. If I have three, I
> might find use for it as well: One more to be controlled by whatever
> application is running on the system.
> 
> Sure, that may be considered overkill, but declaring that "no one will use
> them" if more than one watchdog is available is just not correct. After
> all, there was a _reason_ for introducing the capability to support more
> than one watchdog into the watchdog subsystem.
> 
> Similar, if there are multiple LPCs with separate GPIO pins on each in the
> system, I don't entirely understand why the GPIO pins on the second chip
> would or should be declared to be unusable. Why ?

I agree with Guenter - I'd like to support and use as many watchdogs and GPIOs 
as available.  High reliability applications often have 2 watchdogs as a data 
point, and more GPIO is always nice!

Can you give more background on your hardware and firmware setup?  Are there 
physically two ICH bridges, or just one that is showing up two times due to a 
firmware bug?  If there are two ICH bridges, how are they wired up to your CPU?  
Understanding your configuration would help others give suggestions on fixes or 
workarounds.

Regards,
Peter

  reply	other threads:[~2014-09-03 18:06 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-02 21:58 [PATCH] x86, lpc, Allow only one load of lpc_ich Prarit Bhargava
2014-09-03  7:43 ` Lee Jones
2014-09-03 10:13   ` Prarit Bhargava
2014-09-03 11:35     ` Lee Jones
2014-09-03 11:55       ` Prarit Bhargava
2014-09-03 12:19         ` Lee Jones
2014-09-03 12:23           ` Prarit Bhargava
2014-09-03 12:36             ` Lee Jones
2014-09-03 15:57             ` Guenter Roeck
2014-09-03 17:29               ` Peter Tyser [this message]
2014-09-03 17:56                 ` Prarit Bhargava
2014-09-03 19:13                   ` Peter Tyser
2014-09-03 20:08                     ` Guenter Roeck
2014-09-03 19:22                   ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1598720.9R5g9ohVoY@petert \
    --to=ptyser@xes-inc.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=prarit@redhat.com \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox