From: Deepak Kumar Singh <deesin@codeaurora.org>
To: bjorn.andersson@linaro.org, clew@codeaurora.org
Cc: mathieu.poirier@linaro.org, linux-arm-msm@vger.kernel.org,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
Arun Kumar Neelakantam <aneela@codeaurora.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Carl Huang <cjhuang@codeaurora.org>,
Necip Fazil Yildiran <necip@google.com>,
netdev@vger.kernel.org (open list:NETWORKING [GENERAL])
Subject: [PATCH V1 4/4] net: qrtr: Check function pointer before calling
Date: Sun, 30 Aug 2020 20:08:12 +0530 [thread overview]
Message-ID: <1598798292-5971-5-git-send-email-deesin@codeaurora.org> (raw)
In-Reply-To: <1598798292-5971-1-git-send-email-deesin@codeaurora.org>
From: Arun Kumar Neelakantam <aneela@codeaurora.org>
sk_error_report callback function called without validating cause the NULL
pointer dereference.
Validate function pointer before using for error report.
---
net/qrtr/qrtr.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/net/qrtr/qrtr.c b/net/qrtr/qrtr.c
index e2dd38e..01cabd3 100644
--- a/net/qrtr/qrtr.c
+++ b/net/qrtr/qrtr.c
@@ -786,7 +786,8 @@ static void qrtr_reset_ports(void)
sock_hold(&ipc->sk);
ipc->sk.sk_err = ENETRESET;
- ipc->sk.sk_error_report(&ipc->sk);
+ if (ipc->sk.sk_error_report)
+ ipc->sk.sk_error_report(&ipc->sk);
sock_put(&ipc->sk);
}
mutex_unlock(&qrtr_port_lock);
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
prev parent reply other threads:[~2020-08-30 14:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-30 14:38 [PATCH V1 0/4] General qrtr fixes Deepak Kumar Singh
2020-08-30 14:38 ` [PATCH V1 1/4] net: qrtr: Do not send packets before hello negotiation Deepak Kumar Singh
2020-08-31 2:18 ` David Miller
2020-08-30 14:38 ` [PATCH V1 2/4] net: qrtr: Add socket mode optimization Deepak Kumar Singh
2020-08-30 14:38 ` [PATCH V1 3/4] net: qrtr: Change port allocation to use cyclic idr Deepak Kumar Singh
2020-08-30 18:51 ` kernel test robot
2020-08-30 14:38 ` Deepak Kumar Singh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1598798292-5971-5-git-send-email-deesin@codeaurora.org \
--to=deesin@codeaurora.org \
--cc=aneela@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=cjhuang@codeaurora.org \
--cc=clew@codeaurora.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mathieu.poirier@linaro.org \
--cc=necip@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox