Re: [PATCH: V2 2/2] gpio: tc35894: Disable Direct KBD interrupts to enable gpio irq

Lee Jones
2020-09-08T16:41:09Z

On Thu, 03 Sep 2020, dillon.minfei@gmail.com wrote:

> From: dillon min <dillon.minfei@gmail.com>
>
> On tc35894, have to disable direct keypad interrupts to make
> it as general purpose interrupts functionality work.
> if not, after chip reset, IRQST(0x91) will always 0x20,
> IRQN always low level, can't be clear.
>
> Configure DIRECTx to enable general purpose gpio mode,
> else read GPIOMISx register always zero in irq routine.
>
> verified on tc35894, need more test on other tc3589x.
>
> Signed-off-by: dillon min <dillon.minfei@gmail.com>
> ---
>
> V1 -> V2:
> Add DIRECTx register configuration to active general purpose gpio mode.
>
> drivers/gpio/gpio-tc3589x.c | 18 ++++++++++++++++--

> include/linux/mfd/tc3589x.h | 6 ++++++

Acked-by: Lee Jones <lee.jones@linaro.org>

--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog