From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78EF2305682; Fri, 15 May 2026 15:39:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778859569; cv=none; b=cFAJrcEdfP1csyTV/i3zKrUXDDVH+e+o39biXWU6syNX9X30NR5rIY3yk/QvlVgeI/xec++79UnHsCIjcgsOYzoSIeL2HqTHDbxSI1QfAEd6gSAjOb89KbQ6j10mnJIDIwgY7pPdaOMBHZ6Cn80FribrxR0THXWJva+XD/vk3NE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778859569; c=relaxed/simple; bh=T1eEHSyyLgSbr9sArcALV84p9lrY1225gvm0yy3XBic=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=hXCsHy8TkxlY1sVPdiGPJpgLq6BsXjqbDS2EYCD0o13n2qAfUJF01V5E9v3VCD/qW24zKBv4DhDQEezbM4DmKksJ5xz9Y4ULzFU1Ikh2BsU6A/H7eVZW/QxsWA3EexYc1B6m4JOmQ1y1bk70R5lgJxZHzHVpBwPQxTUwl0pg0qQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Ti9afzSK; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Ti9afzSK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 849EDC2BCC9; Fri, 15 May 2026 15:39:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778859569; bh=T1eEHSyyLgSbr9sArcALV84p9lrY1225gvm0yy3XBic=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Ti9afzSKKaWFunffGxlAhThltdbqXXiVdXsgZwgG7nCUZ5FqbXHAF9ygSYSJRh5/B GP7bxBJyzclV3ZeyD+iuU3SAG4pS5n17opkGTBS7DhWAHjIqRl0HLbVGnXqfg1qAEd 92L83B2bWUKbjnAapqw1LBwXU38A4C1f3By86jeiJ8kwB6HIlFDFx8wromI4jjM2o7 vgNAYyRnf0j5MZ08V4QrvCCCTnSpNFN/wL2HHMT1uABOfdXKlgtsvWK5NSDwdwvmi9 qoVcAVl7iK1iVykPoJk4Gdk0MN1vTN1JvkQTvON4CJr3g6rN1IOiLj/MfViwqi9RLJ c6RguukAQL0FA== Message-ID: <159d813e-1f2d-420a-bfa7-48ac8f533db5@kernel.org> Date: Fri, 15 May 2026 17:39:23 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/4] dt-bindings: phy: qcom,msm8998-qmp-usb3-phy: Add support for Shikra To: Krishna Kurapati Cc: Neil Armstrong , Vinod Koul , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Xiangxu Yin , Johan Hovold , Loic Poulain , Kathiravan Thirumoorthy , Dmitry Baryshkov , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260504170659.282532-1-krishna.kurapati@oss.qualcomm.com> <20260504170659.282532-3-krishna.kurapati@oss.qualcomm.com> <20260505-gifted-salamander-of-prowess-5107a6@quoll> <8cd564af-9646-40c5-a8ef-c7197fb3cfe9@kernel.org> <95b567cc-b83c-4154-9520-e624555f1882@oss.qualcomm.com> <29571bdd-23bf-42a7-a9e3-918a28c79700@kernel.org> <62161822-2365-4ec7-80f7-8660bdadb177@oss.qualcomm.com> <40b5e0f6-bc61-4750-9560-bdcc268f0fe3@kernel.org> <5baeeeed-7c18-46f7-82a3-5bb299ba05ef@kernel.org> <42ba6ac7-306a-419f-96b6-3427c51ef567@oss.qualcomm.com> <9ed7c714-07c1-48de-8d27-cbe24356c606@kernel.org> <34586ed6-4f78-490f-a916-baf7657cca7a@oss.qualcomm.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <34586ed6-4f78-490f-a916-baf7657cca7a@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 15/05/2026 17:36, Krishna Kurapati wrote: > > > On 5/14/2026 8:07 PM, Krzysztof Kozlowski wrote: >> On 14/05/2026 08:22, Krishna Kurapati wrote: >>> >>> >>> On 5/14/2026 12:26 AM, Krzysztof Kozlowski wrote: >>>> On 07/05/2026 13:37, Krishna Kurapati wrote: >>>>> >>>>> >>>>> On 5/5/2026 7:30 PM, Krzysztof Kozlowski wrote: >>>>>> On 05/05/2026 15:57, Krishna Kurapati wrote: >>>>>>> >>>>>>> >>>>>>> On 5/5/2026 6:59 PM, Krzysztof Kozlowski wrote: >>>>>>>> On 05/05/2026 15:27, Krishna Kurapati wrote: >>>>>>>>> >>>>>>>>> >>>>>>>>> On 5/5/2026 4:22 PM, Krzysztof Kozlowski wrote: >>>>>>>>>> On 05/05/2026 12:49, Krzysztof Kozlowski wrote: >>>>>>>>>>> On Mon, May 04, 2026 at 10:36:57PM +0530, Krishna Kurapati wrote: >>>>>>>>>>>> Declare the USB-C QMP PHY present on the Qualcomm Shikra platform. >>>>>>>>>>>> >>>>>>>>>>>> Signed-off-by: Krishna Kurapati >>>>>>>>>>>> --- >>>>>>>>>>>> .../devicetree/bindings/phy/qcom,msm8998-qmp-usb3-phy.yaml | 2 ++ >>>>>>>>>>>> 1 file changed, 2 insertions(+) >>>>>>>>>>> >>>>>>>>>>> Reviewed-by: Krzysztof Kozlowski >>>>>>>>>> >>>>>>>>>> ... and then I looked at the driver. So un-reviewed. Devices are clearly >>>>>>>>>> compatible. If not, explain what is not compatible. >>>>>>>>>> >>>>>>>>> Talos uses GCC_USB3_PRIM_PHY_AUX_CLK. >>>>>>>>> >>>>>>>>> In Shikra, we are using GCC_USB3_PRIM_PHY_COM_AUX_CLK. We don't have >>>>>>>>> GCC_USB3_PRIM_PHY_AUX_CLK. >>>>>>>>> >>>>>>>>> Hence, I didn't use a fallback compatible. >>>>>>>> >>>>>>>> This still explains nothing. How different clock makes interface for SW >>>>>>>> incompatible exactly? >>>>>>>> >>>>>>> So I went by the naming. AUX vs COM_AUX. >>>>>> >>>>>> The naming does not matter. If the clock is called >>>>>> "no_one_expects_spanish_inquisition", does that make software >>>>>> incompatible? Why would the name itself matter? >>>>>> >>>>>>> >>>>>>> Can I use a fallback compatible and in DT vote for "COM_AUX" clock with >>>>>>> clock-names mentioning "aux" ? >>>>>> >>>>>> I don't know, I asked what is different in software interface. >>>>>> >>>>> >>>>> Hi Krzysztof, >>>>> >>>>> I checked with the hw team here and found out two things. >>>>> >>>>> 1. Shikra is a spinoff of Agatti and its sw interface (clocks used and >>>>> regulators used) is the same as agatti. >>>>> >>>>> 2. I thought we could use qcm2290 as a fallback since the phy register >>>>> init sequence is the same for Talos/Shikra/Agatti. The difference >>>>> between Talos and agatti when checked in the driver was the init load >>>>> settings. I checked with the hw team and they suggested using the init >>>>> load settings which talos was using. >>>>> >>>>> Hence both these compatibles (qcm2290 and qcs615) cannot be used as >>>>> fallback for Shikra. >>>> >>>> Then I do not understand why you are using qcs615_usb3phy_cfg for >>>> Shikra. You say that the initialization is different, but you use >>>> exactly the same initialization. So in a meaning of compatibility >>>> between hardware for Devicetree they are compatible. >>>> >>> Hi Krzysztof, >>> >>> There are 3 things: >>> >>> 1. Clocks used: >>> -> Talos supports AUX Clock since it supports DP over USB. >>> -> Agatti and Shikra use COM_AUX clock since they dont support DP over USB. >>> >>> 2. Phy register Init sequence - same for all 3 targets >>> >>> 3. Regulator init load: >>> -> Different for both Talos and Agatti >>> -> Recommendation is to use Talos regulator load values. >>> >>> SW interface wise, shikra is comaptible with agatti. If we use agatti as >>> fallback, we would end up using the platform data of Agatti where the >>> regulator init load is not suitable for Shikra. Hence not using Agatti >>> as fallback. >>> >>> Coming to driver changes, I used qcs615_cfg because it has required phy >>> register sequence and regulator init load as needed by shikra. >> >> So is it compatible with QCS615? If not, then something is incomplete or >> confusing. The driver uses the same software interface. >> > Sorry for the confusion. The Talos compatible represents the USB/DP PHY > with aux clock input, while Shikra is a USB-only PHY with com_aux input > clock, so the two PHYs are not compatible with each other. > > In the Linux driver implementation the match data is currently used only > to affect the init sequence and regulator init load and here Shikra can > reuse the Talos match data structure. > I wrote three times already, not writing anymore. You still did not answer the problem here. Best regards, Krzysztof