From: Manisha Singh <masingh.linux@gmail.com>
To: Philipp Hortmann <philipp.g.hortmann@gmail.com>,
florian.c.schilhabel@googlemail.com, gregkh@linuxfoundation.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] staging: rtl8712: Calculate size from pointer
Date: Thu, 29 Aug 2024 03:01:57 +0530 [thread overview]
Message-ID: <15c72a61-9592-4427-8e71-e662e4a1d205@gmail.com> (raw)
In-Reply-To: <bbd42daa-319e-4390-99ac-7bf874fd0007@gmail.com>
On 8/29/24 02:45, Philipp Hortmann wrote:
> On 8/28/24 22:45, Manisha Singh wrote:
>> Calculate the size from the pointer instead of struct
>>
> Hi Manisha,
>
> the first line of the description is good. Please just add the why (to
> adhere to kernel coding style?) and the "." to make it a full sentence.
>
> Omit the next two lines.
>> CHECK: Prefer kmalloc(sizeof(*pintf_hdl->pintfpriv)...) over
>> kmalloc(sizeof(struct intf_priv)...)
>>
>
> Thanks for your support.
>
> Bye Philipp
>
Sure, will do that.
Thanks for reviewing.
Manisha
next prev parent reply other threads:[~2024-08-28 21:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-28 20:45 [PATCH v2 1/2] staging: rtl8712: Fix style issues in rtl871x_io.c Manisha Singh
2024-08-28 20:45 ` [PATCH v2 2/2] staging: rtl8712: Calculate size from pointer Manisha Singh
2024-08-28 21:15 ` Philipp Hortmann
2024-08-28 21:31 ` Manisha Singh [this message]
2024-08-28 21:08 ` [PATCH v2 1/2] staging: rtl8712: Fix style issues in rtl871x_io.c Philipp Hortmann
2024-08-28 21:34 ` Manisha Singh
2024-08-29 9:36 ` Dan Carpenter
2024-08-29 18:59 ` Philipp Hortmann
2024-08-29 19:34 ` Dan Carpenter
2024-09-01 8:36 ` Manisha Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15c72a61-9592-4427-8e71-e662e4a1d205@gmail.com \
--to=masingh.linux@gmail.com \
--cc=florian.c.schilhabel@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=philipp.g.hortmann@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox