From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934000AbcJaGAN (ORCPT ); Mon, 31 Oct 2016 02:00:13 -0400 Received: from nat-hk.nvidia.com ([203.18.50.4]:26493 "EHLO hkmmgate101.nvidia.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1759318AbcJaGAM (ORCPT ); Mon, 31 Oct 2016 02:00:12 -0400 X-PGP-Universal: processed; by hkpgpgate102.nvidia.com on Sun, 30 Oct 2016 23:00:08 -0700 Subject: Re: [PATCH v10 10/19] vfio iommu: Add blocking notifier to notify DMA_UNMAP To: Jike Song References: <1477517366-27871-1-git-send-email-kwankhede@nvidia.com> <1477517366-27871-11-git-send-email-kwankhede@nvidia.com> <5816BF70.4060601@intel.com> CC: , , , , , , , , X-Nvconfidentiality: public From: Kirti Wankhede Message-ID: <15d36902-418e-74d8-0405-1efa21a265bb@nvidia.com> Date: Mon, 31 Oct 2016 11:29:01 +0530 MIME-Version: 1.0 In-Reply-To: <5816BF70.4060601@intel.com> X-Originating-IP: [10.24.70.244] X-ClientProxiedBy: BGMAIL101.nvidia.com (10.25.59.10) To DRBGMAIL102.nvidia.com (10.18.16.21) Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/31/2016 9:20 AM, Jike Song wrote: > On 10/27/2016 05:29 AM, Kirti Wankhede wrote: >> Added blocking notifier to IOMMU TYPE1 driver to notify vendor drivers >> about DMA_UNMAP. >> Exported two APIs vfio_register_notifier() and vfio_unregister_notifier(). >> Vendor driver should register notifer using these APIs. >> Vendor driver should use VFIO_IOMMU_NOTIFY_DMA_UNMAP action to invalidate >> mappings. >> >> Signed-off-by: Kirti Wankhede >> Signed-off-by: Neo Jia >> Change-Id: I5910d0024d6be87f3e8d3e0ca0eaeaaa0b17f271 >> --- >> drivers/vfio/vfio.c | 73 +++++++++++++++++++++++++++++++++ >> drivers/vfio/vfio_iommu_type1.c | 89 ++++++++++++++++++++++++++++++++++++----- >> include/linux/vfio.h | 11 +++++ >> 3 files changed, 163 insertions(+), 10 deletions(-) >> >> diff --git a/drivers/vfio/vfio.c b/drivers/vfio/vfio.c >> index 28b50ca14c52..ff05ac6b1e90 100644 >> --- a/drivers/vfio/vfio.c >> +++ b/drivers/vfio/vfio.c >> @@ -1891,6 +1891,79 @@ err_unpin_pages: >> } >> EXPORT_SYMBOL(vfio_unpin_pages); >> >> +int vfio_register_notifier(struct device *dev, struct notifier_block *nb) >> +{ > > Hi Kirti, > > Given that below 4 methods are members of vfio_iommu_driver_ops: > > pin_pages > unpin_pages > register_notifier > unregister_notifier > > the names of exposed VFIO APIs could possibly be clearer: > > vfio_iommu_pin_pages > vfio_iommu_unpin_pages > vfio_iommu_register_notifier > vfio_iommu_unreigster_nodier > Hey Jike, I had followed the same style as other members in this structure: attach_group detach_group Thanks, Kirti