From: Priyansh Jain <priyansh.jain@oss.qualcomm.com>
To: Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>,
Amit Kucheria <amitk@kernel.org>,
Thara Gopinath <thara.gopinath@gmail.com>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Daniel Lezcano <daniel.lezcano@kernel.org>,
Zhang Rui <rui.zhang@intel.com>,
Lukasz Luba <lukasz.luba@arm.com>
Cc: linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, manaf.pallikunhi@oss.qualcomm.com
Subject: Re: [PATCH v3] thermal: qcom: tsens: atomic temperature read with hardware-guided retries
Date: Wed, 13 May 2026 10:43:20 +0530 [thread overview]
Message-ID: <15e8fb71-1eb0-4440-a8cf-26f19f66b2bb@oss.qualcomm.com> (raw)
In-Reply-To: <eab8dcf5-080e-45c2-985c-b0711185bed9@oss.qualcomm.com>
On 12-05-2026 02:59 pm, Daniel Lezcano wrote:
> On 5/12/26 11:19, Daniel Lezcano wrote:
>
> [ ... ]
>
>>> Signed-off-by: Priyansh Jain <priyansh.jain@oss.qualcomm.com>
>>> ---
>>
>> Applied, thanks
>
> and dropped because of:
>
>
> drivers/thermal/qcom/tsens.c:819:9: error: this ‘if’ clause does not
> guard... [-Werror=misleading-indentation]
> 819 | if (!ret)
> | ^~
> /home/dlezcano/Work/src/linux/thermal/drivers/thermal/qcom/
> tsens.c:822:17: note: ...this statement, but the latter is misleadingly
> indented as if it were guarded by the if’
> 822 | return ret;
> | ^~~~~~
> cc1: all warnings being treated as errors
>
> Please next time test your changes before sending
Yes, I compiled the changes without the indentation flag enabled, which
caused this issue to be missed during compilation. I will take care to
avoid this going forward and will fix it in the next patch.
Thanks,
Priyansh
>
> Thanks
prev parent reply other threads:[~2026-05-13 5:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-11 7:10 [PATCH v3] thermal: qcom: tsens: atomic temperature read with hardware-guided retries Priyansh Jain
2026-05-12 9:19 ` Daniel Lezcano
2026-05-12 9:29 ` Daniel Lezcano
2026-05-13 5:13 ` Priyansh Jain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15e8fb71-1eb0-4440-a8cf-26f19f66b2bb@oss.qualcomm.com \
--to=priyansh.jain@oss.qualcomm.com \
--cc=amitk@kernel.org \
--cc=daniel.lezcano@kernel.org \
--cc=daniel.lezcano@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=manaf.pallikunhi@oss.qualcomm.com \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
--cc=thara.gopinath@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox