Re: [PATCH v2] platform/x86/intel/ifs: Update documentation to match current availability of firmware images

["Joseph, Jithu" <jithu.joseph@intel.com>]

On 1/21/2025 10:39 AM, Anisse Astier wrote:
> Firmware images necessary for certain tests in the In-field scan[1] test
> suite are not available at the moment[2], and require having access to
> at least an Intel customer account[3].
> 
> Update documentation to match current state, it can be updated again
> when the images are finally published.
> 
> [1] https://www.intel.com/content/www/us/en/support/articles/000099537/processors/intel-xeon-processors.html
> [2] https://cdrdv2.intel.com/v1/dl/getContent/826383?explicitVersion=true
> [3] https://www.intel.com/content/www/us/en/secure/design/confidential/software-kits/kit-details.html?kitId=815180
> 
> Signed-off-by: Anisse Astier <anisse@astier.eu>
> ---
> Changes since v1:
>  - update commit message to clarify that only some tests need the firmware
>    images, thanks Jithu for the suggestion!
> 
> Regards,
> 
> Anisse
> ---
>  drivers/platform/x86/intel/ifs/ifs.h | 11 +++++++----
>  1 file changed, 7 insertions(+), 4 deletions(-)

Looks good to me.

Reviewed-by: Jithu Joseph <jithu.joseph@intel.com>

> 
> diff --git a/drivers/platform/x86/intel/ifs/ifs.h b/drivers/platform/x86/intel/ifs/ifs.h
> index 5c3c0dfa1bf8..9a7ad9cc9d08 100644
> --- a/drivers/platform/x86/intel/ifs/ifs.h
> +++ b/drivers/platform/x86/intel/ifs/ifs.h
> @@ -23,9 +23,11 @@
>   * IFS Image
>   * ---------
>   *
> - * Intel provides a firmware file containing the scan tests via
> - * github [#f1]_.  Similar to microcode there is a separate file for each
> - * family-model-stepping. IFS Images are not applicable for some test types.
> + * As of early 2025, Intel provides the firmware files containing the scan tests
> + * to select customers [#f1]_. When this driver was merged in 2022, it was
> + * announced that firmware files would be available via github [#f2]_. Similar
> + * to microcode there is a separate file for each family-model-stepping. IFS
> + * Images are not applicable for some test types.
>   * Wherever applicable the sysfs directory would provide a "current_batch" file
>   * (see below) for loading the image.
>   *
> @@ -125,7 +127,8 @@
>   * 2) Hardware allows for some number of cores to be tested in parallel.
>   * The driver does not make use of this, it only tests one core at a time.
>   *
> - * .. [#f1] https://github.com/intel/TBD
> + * .. [#f1] https://www.intel.com/content/www/us/en/support/articles/000099537/processors/intel-xeon-processors.html
> + * .. [#f2] https://github.com/intel/TBD
>   *
>   *
>   * Structural Based Functional Test at Field (SBAF):

Thanks
Jithu