Re: [PATCH v6 3/5] Asoc:qcom:lpass-cpu:Update dts property read API

Rohit Kumar
2020-09-22T12:53:23Z

On 9/22/2020 5:13 PM, Mark Brown wrote:
> On Tue, Sep 22, 2020 at 12:22:38PM +0100, Srinivas Kandagatla wrote:
>> On 22/09/2020 12:08, Mark Brown wrote:
>> I agree with you on this and I see the point, but Rob had a very different
>> opinion about the reg-names bindings to start with.
>> This topic been discussed in the past with Rob in many instances ex: https://lore.kernel.org/linux-devicetree/CAL_Jsq+MMunmVWqeW9v2RyzsMKP+=kMzeTHNMG4JDHM7Fy0HBg@mail.gmail.com/
>> According to him, reg-names seems to be highly discouraged as it came along
>> for the OMAP folks and was related to the hwmods stuff.
> That's very much specific to reg, it's not true of the use of names in
> general - Rob mentions cases like interrupts for example.

I see that patch to support hdmi adds another reg-name along with
"lpass-lpaif".

So, platform_get_resource_byname() is better option.

+       res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
"lpass-hdmiif");

Thanks,

Rohit

--
Qualcomm INDIA, on behalf of Qualcomm Innovation Center, Inc.is a member
of the Code Aurora Forum, hosted by the Linux Foundation.