Re: [PATCH v3 3/4] venus: core: vote with average bandwidth and peak bandwidth as zero

Stephen Boyd
2020-09-24T07:53:07Z

Quoting Mansur Alisha Shaik (2020-09-23 23:51:05)
> As per bandwidth table video driver is voting with average bandwidth
> for "video-mem" and "cpu-cfg" paths as peak bandwidth is zero
> in bandwidth table.
>
> Fixes: 7482a983d ("media: venus: redesign clocks and pm domains control")
> Signed-off-by: Mansur Alisha Shaik <mansur@codeaurora.org>
> ---
> Changes in v3:
> - Added fixes tag
>
> drivers/media/platform/qcom/venus/core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c
> index fa363b8..d5bfd6f 100644
> --- a/drivers/media/platform/qcom/venus/core.c
> +++ b/drivers/media/platform/qcom/venus/core.c
> @@ -385,11 +385,11 @@ static __maybe_unused int venus_runtime_resume(struct device *dev)
> const struct venus_pm_ops *pm_ops = core->pm_ops;
> int ret;
>
> - ret = icc_set_bw(core->video_path, 0, kbps_to_icc(1000));
> + ret = icc_set_bw(core->video_path, kbps_to_icc(20000), 0);

This gets added in the previous patch. Why not put this patch before
that one?

Anyway..

Reviewed-by: Stephen Boyd <swboyd@chromium.org>