Re: [PATCH v2 2/2] regulator: rtmv20: Add DT-binding document for Richtek RTMV20

Mark Brown
2020-09-30T09:43:26Z

[-- Attachment #1: Type: text/plain, Size: 731 bytes --]

On Wed, Sep 30, 2020 at 10:23:49AM +0800, ChiYuan Huang wrote:

> Due to that already merged into your regulator for-next git, may I
> send the patch to fix Rob's comment?

Of course, yes please.

> And I also found one line need to be added into rtmv20 probe phase.
> Please check below.
> /*
> * keep in shutdown mode to minimize the current consumption
> * and also mark regcache as dirty
> */
> + regcache_cache_only(priv->regmap, true);
> regcache_mark_dirty(priv->regmap);
> gpiod_set_value(priv->enable_gpio, 0);
>
> Can I directly merge into one that includes Rob's comment and the
> above line to be added?

Please make it a separate patch.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]