From: Rishabh Bhatnagar <rishabhb@codeaurora.org>
To: linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
bjorn.andersson@linaro.org
Cc: tsoni@codeaurora.org, psodagud@codeaurora.org,
sidgup@codeaurora.org,
Rishabh Bhatnagar <rishabhb@codeaurora.org>
Subject: [PATCH v6 0/3] Move recovery/coredump configuration to sysfs
Date: Mon, 28 Sep 2020 15:17:33 -0700 [thread overview]
Message-ID: <1601331456-20432-1-git-send-email-rishabhb@codeaurora.org> (raw)
From Android R onwards Google has restricted access to debugfs in user
and user-debug builds. This restricts access to most of the features
exposed through debugfs. 'Coredump' and 'Recovery' are critical
interfaces that are required for remoteproc to work on Qualcomm Chipsets.
Coredump configuration needs to be set to "inline" in debug/test builds
and "disabled" in production builds. Whereas recovery needs to be
"disabled" for debugging purposes and "enabled" on production builds.
This patch series removes the recovery/coredump entries from debugfs
and moves them to sysfs. Also, this disables the coredump collection
by default as this is a requirement for production devices.
Changelog:
v6 -> v5:
- Disable coredump collection by default
- Rename the "default" configuration to "enabled" to avoid confusion
v5 -> v4:
- Fix the cover-letter of tha patch series.
v4 -> v3:
- Remove the feature flag to expose recovery/coredump
v3 -> v2:
- Remove the coredump/recovery entries from debugfs
- Expose recovery/coredump from sysfs under a feature flag
v1 -> v2:
- Correct the contact name in the sysfs documentation.
- Remove the redundant write documentation for coredump/recovery sysfs
- Add a feature flag to make this interface switch configurable.
Rishabh Bhatnagar (3):
remoteproc: Move coredump configuration to sysfs
remoteproc: Move recovery configuration to sysfs
remoteproc: Change default dump configuration to "disabled"
Documentation/ABI/testing/sysfs-class-remoteproc | 46 +++++++
drivers/remoteproc/remoteproc_coredump.c | 6 +-
drivers/remoteproc/remoteproc_debugfs.c | 168 -----------------------
drivers/remoteproc/remoteproc_sysfs.c | 120 ++++++++++++++++
include/linux/remoteproc.h | 8 +-
5 files changed, 173 insertions(+), 175 deletions(-)
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next reply other threads:[~2020-09-28 23:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 22:17 Rishabh Bhatnagar [this message]
2020-09-28 22:17 ` [PATCH v6 1/3] remoteproc: Move coredump configuration to sysfs Rishabh Bhatnagar
2020-09-29 3:24 ` Bjorn Andersson
2020-09-28 22:17 ` [PATCH v6 2/3] remoteproc: Move recovery " Rishabh Bhatnagar
2020-09-30 8:11 ` Arnaud POULIQUEN
2020-09-30 8:58 ` Arnaud POULIQUEN
2020-09-28 22:17 ` [PATCH v6 3/3] remoteproc: Change default dump configuration to "disabled" Rishabh Bhatnagar
2020-09-29 8:44 ` [PATCH v6 0/3] Move recovery/coredump configuration to sysfs Arnaud POULIQUEN
2020-09-29 14:33 ` Bjorn Andersson
2020-09-29 17:18 ` Arnaud POULIQUEN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1601331456-20432-1-git-send-email-rishabhb@codeaurora.org \
--to=rishabhb@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=psodagud@codeaurora.org \
--cc=sidgup@codeaurora.org \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox