Re: [PATCH v3 2/2] arm64: dts: qcom: sc7180-trogdor: Add lpass dai link for HDMI

Stephen Boyd
2021-01-15T03:19:07Z

Quoting Srinivasa Rao Mandadapu (2020-09-29 23:42:48)
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> index 5724982..850b43e 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> @@ -231,6 +231,7 @@
>
> audio-jack = <&alc5682>;
>
> + #sound-dai-cells = <0>;
> #address-cells = <1>;
> #size-cells = <0>;
>
> @@ -257,6 +258,17 @@
> sound-dai = <&max98357a>;
> };
> };

Can you please add a newline here?

> + dai-link@2 {
> + link-name = "MultiMedia2";
> + reg = <2>;
> + cpu {
> + sound-dai = <&lpass_cpu 2>;
> + };
> +
> + codec {
> + sound-dai = <&msm_dp>;
> + };
> + };
> };
> };
>
> @@ -782,6 +794,9 @@ hp_i2c: &i2c9 {
> reg = <MI2S_SECONDARY>;
> qcom,playback-sd-lines = <0>;
> };

Can you please add a newline here?

> + hdmi-primary@0 {

This should be hdmi-primary@2 {

Or a more generic node name should be devised. dai@2 perhaps?

> + reg = <LPASS_DP_RX>;
> + };
> };
>