From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935229AbcATKsS (ORCPT ); Wed, 20 Jan 2016 05:48:18 -0500 Received: from mout.kundenserver.de ([212.227.126.133]:53086 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934859AbcATKsI (ORCPT ); Wed, 20 Jan 2016 05:48:08 -0500 From: Arnd Bergmann To: Nicholas Bellinger Cc: qla2xxx-upstream@qlogic.com, "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Alexei Potashnik , Quinn Tran , Himanshu Madhani , Hannes Reinecke Subject: [PATCH] scsi: qla2xxxx: avoid type mismatch in comparison Date: Wed, 20 Jan 2016 11:47:14 +0100 Message-ID: <1603472.f34vvTrhuN@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:QvohloIs2o79Ccu+d2aGpp1CpnYQInJ900B2nh2GcNuA5xUFDed hTBgSCOHncv1TU70xcNB6okw89BHzu7GUb0GI6iY6pbro+2OrLDtBoZGNwTWc5Q1/6ifenh 6JmjKYBJ1S9Gppf6v5WAsnQ32Ae7V+oJKPVkVz39isnVa56BGiFR+HKvgbMLuTnKRb9w0V2 UCzklHkuHTeVZcKDP7Rsg== X-UI-Out-Filterresults: notjunk:1;V01:K0:H8LiaIwsJxE=:l9ZFH12nUYziN6ubLr42qQ MIrE8P19zVjx4e+ONSpLPVR0x1pvM8/vBKhfkqadIYzyC0FSqkYwTwW4Dg+5mgnQ9xhkTOrg7 BvPbL1RBpFBI3QSOaROgXr1BHrGma7KTcdR40xmnUxzA1zXJQ7twrdlg+mZMqiti5rEVrHTGz zqMgk03eHa7f3yuLmO2eRdSXhg1igAZnw2zMxCPCJRS/b1gdV/ujNph3u5VZ3uIPFcN6ZmNmU Yopknt/yalK9+WYmn8uw2cjYg5zaKk9nQJgJ95Dd1/d9T4HhmdoiLSDCRjWvUFzpl2NhGHXPH /a+hAj/AubYXKkpehi5WsSr/kT4ZMwI96Rjv3YPXKy2Mpx2WxjkqpEXOeEx3LUrbMeg36L/cg cMhYterRikpBR5gpVPuzYa2wuqXiYN2hobRGErW4F7qCzAxEmvoUyZyx5vJyjsXvCkeUI0Ohi lA2TLc8+i6TLDKKvkK19BwfuRVQYFyRpxKvCEUdKy2SumCm547GcU99eEu6A30BCslnxoJOkl LnoZ+0/E+l3S1V+AYdIK1EjeagrzIDGV4IhcTZ57MHD9Vv4Qs6tZQX1NDbTlfe/JNhReCmpKo iebAvK3up8qUCeezhkPtTNbagQD6fXeUk8pxQmGO2wP04a+CO3O9EqR2zffyqgwrt5iEWB4mR WwP2uRkFrX3JurfOyPA5WYuaqetxOLVr0UvkZ4vluW8CnmvidaRW0RqxJLWeI/kvKOG0Ln6/X ODsDn5arjx0lYLAD Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A recent bug fix added code that does bool logged_out = (status & 0xFFFF); if (logged_out == CTIO_PORT_LOGGED_OUT) ... This looks wrong because we are comparing a boolean with an integer constant, ang gcc warns about it accordingly: drivers/scsi/qla2xxx/qla_target.c: In function 'qlt_do_ctio_completion': drivers/scsi/qla2xxx/qla_target.c:3587:20: warning: comparison of constant '41' with boolean expression is always false [-Wbool-compare] (logged_out == CTIO_PORT_LOGGED_OUT) ? The correct fix is presumably to make that variable an 'int'. Signed-off-by: Arnd Bergmann Fixes: 71cdc0796465 ("qla2xxx: Delete session if initiator is gone from FW") --- The patch introducing this is currenly in linux-next through the target-updates/for-next branch. diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c index c7ab9e69c881..8075a4cdb45c 100644 --- a/drivers/scsi/qla2xxx/qla_target.c +++ b/drivers/scsi/qla2xxx/qla_target.c @@ -3580,7 +3580,7 @@ static void qlt_do_ctio_completion(struct scsi_qla_host *vha, uint32_t handle, case CTIO_PORT_LOGGED_OUT: case CTIO_PORT_UNAVAILABLE: { - bool logged_out = (status & 0xFFFF); + int logged_out = (status & 0xFFFF); ql_dbg(ql_dbg_tgt_mgt, vha, 0xf059, "qla_target(%d): CTIO with %s status %x " "received (state %x, se_cmd %p)\n", vha->vp_idx,