From: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
To: "Arnaldo Carvalho de Melo" <acme@kernel.org>,
"Alexander Shishkin" <alexander.shishkin@linux.intel.com>,
"Al Grant" <Al.Grant@arm.com>,
"André Przywara" <andre.przywara@arm.com>,
"Ian Rogers" <irogers@google.com>,
"James Clark" <james.clark@arm.com>,
"John Garry" <john.garry@huawei.com>,
"Jiri Olsa" <jolsa@redhat.com>, "Leo Yan" <leo.yan@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, "Wei Li" <liwei391@huawei.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Mathieu Poirier" <mathieu.poirier@linaro.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Namhyung Kim" <namhyung@kernel.org>,
"Peter Zijlstra" <peterz@infradead.org>,
"Kemeng Shi" <shikemeng@huawei.com>,
"Will Deacon" <will@kernel.org>,
"Madhavan Srinivasan" <maddy@linux.ibm.com>
Subject: Re: [PATCH v3 8/9] perf mem: Return NULL for event 'ldst' on PowerPC
Date: Wed, 28 Oct 2020 15:05:03 +0530 [thread overview]
Message-ID: <1603877629.hjro28ddup.naveen@linux.ibm.com> (raw)
In-Reply-To: <20201028063813.8562-9-leo.yan@linaro.org>
[+ Maddy]
Leo Yan wrote:
> If user specifies event type "ldst", PowerPC's perf_mem_events__name()
> will wrongly return the store event name "cpu/mem-stores/".
>
> This patch changes to return NULL for the event "ldst" on PowerPC.
>
> Signed-off-by: Leo Yan <leo.yan@linaro.org>
> ---
> tools/perf/arch/powerpc/util/mem-events.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/arch/powerpc/util/mem-events.c b/tools/perf/arch/powerpc/util/mem-events.c
> index 07fb5e049488..90c5a0760685 100644
> --- a/tools/perf/arch/powerpc/util/mem-events.c
> +++ b/tools/perf/arch/powerpc/util/mem-events.c
> @@ -7,6 +7,8 @@ char *perf_mem_events__name(int i)
> {
> if (i == PERF_MEM_EVENTS__LOAD)
> return (char *) "cpu/mem-loads/";
> -
> - return (char *) "cpu/mem-stores/";
> + else if (i == PERF_MEM_EVENTS__STORE)
> + return (char *) "cpu/mem-stores/";
> + else
> + return NULL;
> }
> --
> 2.17.1
>
>
next prev parent reply other threads:[~2020-10-28 21:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 6:38 [PATCH v3 0/9] perf mem/c2c: Support AUX trace Leo Yan
2020-10-28 6:38 ` [PATCH v3 1/9] perf mem: Search event name with more flexible path Leo Yan
2020-10-28 6:38 ` [PATCH v3 2/9] perf mem: Introduce weak function perf_mem_events__ptr() Leo Yan
2020-10-28 6:38 ` [PATCH v3 3/9] perf mem: Support new memory event PERF_MEM_EVENTS__LOAD_STORE Leo Yan
2020-10-31 20:23 ` Jiri Olsa
2020-11-02 9:38 ` Leo Yan
2020-10-28 6:38 ` [PATCH v3 4/9] perf mem: Only initialize memory event for recording Leo Yan
2020-10-30 1:04 ` Ian Rogers
2020-10-28 6:38 ` [PATCH v3 5/9] perf mem: Support AUX trace Leo Yan
2020-10-28 6:38 ` [PATCH v3 6/9] perf c2c: " Leo Yan
2020-10-31 20:21 ` Jiri Olsa
2020-11-02 10:08 ` Leo Yan
2020-11-02 16:35 ` Jiri Olsa
2020-10-28 6:38 ` [PATCH v3 7/9] perf mem: Support Arm SPE events Leo Yan
2020-10-28 6:38 ` [PATCH v3 8/9] perf mem: Return NULL for event 'ldst' on PowerPC Leo Yan
2020-10-28 9:35 ` Naveen N. Rao [this message]
2020-10-28 6:38 ` [PATCH v3 9/9] perf mem: Document event type 'ldst' Leo Yan
2020-10-30 1:10 ` Ian Rogers
2020-10-30 1:49 ` Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1603877629.hjro28ddup.naveen@linux.ibm.com \
--to=naveen.n.rao@linux.vnet.ibm.com \
--cc=Al.Grant@arm.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=andre.przywara@arm.com \
--cc=irogers@google.com \
--cc=james.clark@arm.com \
--cc=john.garry@huawei.com \
--cc=jolsa@redhat.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liwei391@huawei.com \
--cc=maddy@linux.ibm.com \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=shikemeng@huawei.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).