From: Yi Sun <yi.y.sun@linux.intel.com>
To: joro@8bytes.org, dwmw2@infradead.org, baolu.lu@linux.intel.com,
jean-philippe@linaro.org
Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
yi.l.liu@intel.com, jacob.jun.pan@linux.intel.com,
Liu@vger.kernel.org, Yi Sun <yi.y.sun@linux.intel.com>
Subject: [PATCH v2 2/2] iommu/vt-d: Fix a bug for PDP check in prq_event_thread
Date: Fri, 30 Oct 2020 10:37:24 +0800 [thread overview]
Message-ID: <1604025444-6954-3-git-send-email-yi.y.sun@linux.intel.com> (raw)
In-Reply-To: <1604025444-6954-1-git-send-email-yi.y.sun@linux.intel.com>
From: "Liu, Yi L" <yi.l.liu@intel.com>
In prq_event_thread(), the QI_PGRP_PDP is wrongly set by
'req->pasid_present' which should be replaced to
'req->priv_data_present'.
Fixes: 5b438f4ba315 ("iommu/vt-d: Support page request in scalable mode")
Signed-off-by: Liu, Yi L <yi.l.liu@intel.com>
Signed-off-by: Yi Sun <yi.y.sun@linux.intel.com>
---
drivers/iommu/intel/svm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iommu/intel/svm.c b/drivers/iommu/intel/svm.c
index 7584669..3242ebd 100644
--- a/drivers/iommu/intel/svm.c
+++ b/drivers/iommu/intel/svm.c
@@ -1035,7 +1035,7 @@ static irqreturn_t prq_event_thread(int irq, void *d)
resp.qw0 = QI_PGRP_PASID(req->pasid) |
QI_PGRP_DID(req->rid) |
QI_PGRP_PASID_P(req->pasid_present) |
- QI_PGRP_PDP(req->pasid_present) |
+ QI_PGRP_PDP(req->priv_data_present) |
QI_PGRP_RESP_CODE(result) |
QI_PGRP_RESP_TYPE;
resp.qw1 = QI_PGRP_IDX(req->prg_index) |
--
2.7.4
next prev parent reply other threads:[~2020-10-30 2:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-30 2:37 [PATCH v2 0/2] iommu: Fix a few issues related to PRQ Yi Sun
2020-10-30 2:37 ` [PATCH v2 1/2] iommu/vt-d: Fix sid not set issue in intel_svm_bind_gpasid() Yi Sun
2020-10-30 12:48 ` Lu Baolu
2020-10-30 2:37 ` Yi Sun [this message]
2020-10-30 12:49 ` [PATCH v2 2/2] iommu/vt-d: Fix a bug for PDP check in prq_event_thread Lu Baolu
2020-11-03 13:37 ` [PATCH v2 0/2] iommu: Fix a few issues related to PRQ Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1604025444-6954-3-git-send-email-yi.y.sun@linux.intel.com \
--to=yi.y.sun@linux.intel.com \
--cc=Liu@vger.kernel.org \
--cc=baolu.lu@linux.intel.com \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jacob.jun.pan@linux.intel.com \
--cc=jean-philippe@linaro.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox