From: Chunfeng Yun <chunfeng.yun@mediatek.com>
To: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Cc: Philipp Zabel <p.zabel@pengutronix.de>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Matthias Brugger <matthias.bgg@gmail.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
DRI Development <dri-devel@lists.freedesktop.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Vinod Koul <vkoul@kernel.org>
Subject: Re: [PATCH 2/3] phy: mediatek: Move mtk_mipi_dsi_phy driver into drivers/phy/mediatek folder
Date: Mon, 2 Nov 2020 09:48:32 +0800 [thread overview]
Message-ID: <1604281712.31607.14.camel@mhfsdcap03> (raw)
In-Reply-To: <CAAOTY_8Nf=Lh_JDojKY3oHdTigO=i+BHuvVA+9hYXCzgu-2Cfg@mail.gmail.com>
On Mon, 2020-11-02 at 07:08 +0800, Chun-Kuang Hu wrote:
> + Vinod:
>
> Hi, Chunfeng:
>
> Chunfeng Yun <chunfeng.yun@mediatek.com> 於 2020年10月30日 週五 下午2:24寫道：
> >
> > On Thu, 2020-10-29 at 23:27 +0800, Chun-Kuang Hu wrote:
> > > mtk_mipi_dsi_phy is currently placed inside mediatek drm driver, but it's
> > > more suitable to place a phy driver into phy driver folder, so move
> > > mtk_mipi_dsi_phy driver into phy driver folder.
> > >
> > > Signed-off-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
> > > ---
> > > drivers/gpu/drm/mediatek/Kconfig | 7 -------
> > > drivers/gpu/drm/mediatek/Makefile | 6 ------
> > > drivers/phy/mediatek/Kconfig | 7 +++++++
> > > drivers/phy/mediatek/Makefile | 5 +++++
> > > .../mediatek/phy-mtk-mipi-dsi-mt8173.c} | 2 +-
> > > .../mediatek/phy-mtk-mipi-dsi-mt8183.c} | 2 +-
> > > .../mtk_mipi_tx.c => phy/mediatek/phy-mtk-mipi-dsi.c} | 2 +-
> > > .../mtk_mipi_tx.h => phy/mediatek/phy-mtk-mipi-dsi.h} | 0
> > > 8 files changed, 15 insertions(+), 16 deletions(-)
> > > rename drivers/{gpu/drm/mediatek/mtk_mt8173_mipi_tx.c => phy/mediatek/phy-mtk-mipi-dsi-mt8173.c} (99%)
> > > rename drivers/{gpu/drm/mediatek/mtk_mt8183_mipi_tx.c => phy/mediatek/phy-mtk-mipi-dsi-mt8183.c} (99%)
> > > rename drivers/{gpu/drm/mediatek/mtk_mipi_tx.c => phy/mediatek/phy-mtk-mipi-dsi.c} (99%)
> > > rename drivers/{gpu/drm/mediatek/mtk_mipi_tx.h => phy/mediatek/phy-mtk-mipi-dsi.h} (100%)
> >
> > Reviewed-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
>
> I would like to apply the whole series into my tree, would you please
> give an acked-by tag on this patch, so I could apply this patch into
> my tree.
Acked-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
>
> Regards,
> Chun-Kuang.
>
> >
> > Please add phy maintaniner "Vinod Koul <vkoul@kernel.org>"
> >
> > Thanks
> >
> > >
> > > diff --git a/drivers/gpu/drm/mediatek/Kconfig b/drivers/gpu/drm/mediatek/Kconfig
> > > index 24c4890a6e65..2976d21e9a34 100644
> > > --- a/drivers/gpu/drm/mediatek/Kconfig
> > > +++ b/drivers/gpu/drm/mediatek/Kconfig
> > > @@ -28,10 +28,3 @@ config DRM_MEDIATEK_HDMI
> > > select PHY_MTK_HDMI
> > > help
> > > DRM/KMS HDMI driver for Mediatek SoCs
> > > -
> > > -config PHY_MTK_MIPI_DSI
> > > - tristate "Mediatek MIPI-DSI-PHY Driver"
> > > - depends on ARCH_MEDIATEK && OF
> > > - select GENERIC_PHY
> > > - help
> > > - Support MIPI DSI PHY for Mediatek SoCs.
> > > diff --git a/drivers/gpu/drm/mediatek/Makefile b/drivers/gpu/drm/mediatek/Makefile
> > > index baa188000543..a892edec5563 100644
> > > --- a/drivers/gpu/drm/mediatek/Makefile
> > > +++ b/drivers/gpu/drm/mediatek/Makefile
> > > @@ -19,9 +19,3 @@ mediatek-drm-hdmi-objs := mtk_cec.o \
> > > mtk_hdmi_ddc.o
> > >
> > > obj-$(CONFIG_DRM_MEDIATEK_HDMI) += mediatek-drm-hdmi.o
> > > -
> > > -phy-mtk-mipi-dsi-drv-objs := mtk_mipi_tx.o \
> > > - mtk_mt8173_mipi_tx.o \
> > > - mtk_mt8183_mipi_tx.o
> > > -
> > > -obj-$(CONFIG_PHY_MTK_MIPI_DSI) += phy-mtk-mipi-dsi-drv.o
> > > diff --git a/drivers/phy/mediatek/Kconfig b/drivers/phy/mediatek/Kconfig
> > > index 50c5e9306e19..574b8e6398d2 100644
> > > --- a/drivers/phy/mediatek/Kconfig
> > > +++ b/drivers/phy/mediatek/Kconfig
> > > @@ -42,3 +42,10 @@ config PHY_MTK_HDMI
> > > select GENERIC_PHY
> > > help
> > > Support HDMI PHY for Mediatek SoCs.
> > > +
> > > +config PHY_MTK_MIPI_DSI
> > > + tristate "MediaTek MIPI-DSI Driver"
> > > + depends on ARCH_MEDIATEK && OF
> > > + select GENERIC_PHY
> > > + help
> > > + Support MIPI DSI for Mediatek SoCs.
> > > diff --git a/drivers/phy/mediatek/Makefile b/drivers/phy/mediatek/Makefile
> > > index 6325e38709ed..ace660fbed3a 100644
> > > --- a/drivers/phy/mediatek/Makefile
> > > +++ b/drivers/phy/mediatek/Makefile
> > > @@ -11,3 +11,8 @@ phy-mtk-hdmi-drv-y := phy-mtk-hdmi.o
> > > phy-mtk-hdmi-drv-y += phy-mtk-hdmi-mt2701.o
> > > phy-mtk-hdmi-drv-y += phy-mtk-hdmi-mt8173.o
> > > obj-$(CONFIG_PHY_MTK_HDMI) += phy-mtk-hdmi-drv.o
> > > +
> > > +phy-mtk-mipi-dsi-drv-y := phy-mtk-mipi-dsi.o
> > > +phy-mtk-mipi-dsi-drv-y += phy-mtk-mipi-dsi-mt8173.o
> > > +phy-mtk-mipi-dsi-drv-y += phy-mtk-mipi-dsi-mt8183.o
> > > +obj-$(CONFIG_PHY_MTK_MIPI_DSI) += phy-mtk-mipi-dsi-drv.o
> > > diff --git a/drivers/gpu/drm/mediatek/mtk_mt8173_mipi_tx.c b/drivers/phy/mediatek/phy-mtk-mipi-dsi-mt8173.c
> > > similarity index 99%
> > > rename from drivers/gpu/drm/mediatek/mtk_mt8173_mipi_tx.c
> > > rename to drivers/phy/mediatek/phy-mtk-mipi-dsi-mt8173.c
> > > index f18db14d8b63..7a847954594f 100644
> > > --- a/drivers/gpu/drm/mediatek/mtk_mt8173_mipi_tx.c
> > > +++ b/drivers/phy/mediatek/phy-mtk-mipi-dsi-mt8173.c
> > > @@ -4,7 +4,7 @@
> > > * Author: jitao.shi <jitao.shi@mediatek.com>
> > > */
> > >
> > > -#include "mtk_mipi_tx.h"
> > > +#include "phy-mtk-mipi-dsi.h"
> > >
> > > #define MIPITX_DSI_CON 0x00
> > > #define RG_DSI_LDOCORE_EN BIT(0)
> > > diff --git a/drivers/gpu/drm/mediatek/mtk_mt8183_mipi_tx.c b/drivers/phy/mediatek/phy-mtk-mipi-dsi-mt8183.c
> > > similarity index 99%
> > > rename from drivers/gpu/drm/mediatek/mtk_mt8183_mipi_tx.c
> > > rename to drivers/phy/mediatek/phy-mtk-mipi-dsi-mt8183.c
> > > index 9f3e55aeebb2..99108426d57c 100644
> > > --- a/drivers/gpu/drm/mediatek/mtk_mt8183_mipi_tx.c
> > > +++ b/drivers/phy/mediatek/phy-mtk-mipi-dsi-mt8183.c
> > > @@ -4,7 +4,7 @@
> > > * Author: jitao.shi <jitao.shi@mediatek.com>
> > > */
> > >
> > > -#include "mtk_mipi_tx.h"
> > > +#include "phy-mtk-mipi-dsi.h"
> > >
> > > #define MIPITX_LANE_CON 0x000c
> > > #define RG_DSI_CPHY_T1DRV_EN BIT(0)
> > > diff --git a/drivers/gpu/drm/mediatek/mtk_mipi_tx.c b/drivers/phy/mediatek/phy-mtk-mipi-dsi.c
> > > similarity index 99%
> > > rename from drivers/gpu/drm/mediatek/mtk_mipi_tx.c
> > > rename to drivers/phy/mediatek/phy-mtk-mipi-dsi.c
> > > index f2a892e16c27..18c481251f04 100644
> > > --- a/drivers/gpu/drm/mediatek/mtk_mipi_tx.c
> > > +++ b/drivers/phy/mediatek/phy-mtk-mipi-dsi.c
> > > @@ -3,7 +3,7 @@
> > > * Copyright (c) 2015 MediaTek Inc.
> > > */
> > >
> > > -#include "mtk_mipi_tx.h"
> > > +#include "phy-mtk-mipi-dsi.h"
> > >
> > > inline struct mtk_mipi_tx *mtk_mipi_tx_from_clk_hw(struct clk_hw *hw)
> > > {
> > > diff --git a/drivers/gpu/drm/mediatek/mtk_mipi_tx.h b/drivers/phy/mediatek/phy-mtk-mipi-dsi.h
> > > similarity index 100%
> > > rename from drivers/gpu/drm/mediatek/mtk_mipi_tx.h
> > > rename to drivers/phy/mediatek/phy-mtk-mipi-dsi.h
> >
next prev parent reply other threads:[~2020-11-02 1:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 15:26 [PATCH 0/3] Move Mediatek MIPI DSI PHY driver from DRM folder to PHY folder Chun-Kuang Hu
2020-10-29 15:27 ` [PATCH 1/3] drm/mediatek: Separate mtk_mipi_tx to an independent module Chun-Kuang Hu
2020-10-29 15:27 ` [PATCH 2/3] phy: mediatek: Move mtk_mipi_dsi_phy driver into drivers/phy/mediatek folder Chun-Kuang Hu
2020-10-30 6:24 ` Chunfeng Yun
2020-11-01 23:08 ` Chun-Kuang Hu
2020-11-02 1:48 ` Chunfeng Yun [this message]
2020-11-16 7:25 ` Vinod Koul
2020-11-16 16:17 ` Chun-Kuang Hu
2020-11-16 17:02 ` Vinod Koul
2020-10-29 15:27 ` [PATCH 3/3] MAINTAINERS: add files for Mediatek DRM drivers Chun-Kuang Hu
2020-11-08 3:04 ` Chun-Kuang Hu
2020-11-09 1:47 ` Chunfeng Yun
2020-11-09 23:31 ` [PATCH 0/3] Move Mediatek MIPI DSI PHY driver from DRM folder to PHY folder Chun-Kuang Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1604281712.31607.14.camel@mhfsdcap03 \
--to=chunfeng.yun@mediatek.com \
--cc=airlied@linux.ie \
--cc=chunkuang.hu@kernel.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox