From: Macpaul Lin <macpaul.lin@mediatek.com>
To: Rob Herring <robh@kernel.org>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Mathias Nyman" <mathias.nyman@intel.com>,
"Chunfeng Yun (云春峰)" <Chunfeng.Yun@mediatek.com>,
"Ainge Hsu (徐巧宜)" <ainge.hsu@mediatek.com>,
"Eddie Hung (洪正鑫)" <Eddie.Hung@mediatek.com>,
wsd_upstream <wsd_upstream@mediatek.com>,
"Macpaul Lin" <macpaul@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH v2 1/2] dt-bindings: usb: mediatek,mtk-xhci: add str-clock-on
Date: Fri, 6 Nov 2020 17:58:40 +0800 [thread overview]
Message-ID: <1604656720.24301.24.camel@mtkswgap22> (raw)
In-Reply-To: <1604655965-22418-1-git-send-email-macpaul.lin@mediatek.com>
On Fri, 2020-11-06 at 17:46 +0800, Macpaul Lin wrote:
> Option "mediatek,str-clock-on" means to keep clock on during system
> suspend and resume. Some platform will flush register settings if clock has
> been disabled when system is suspended. Set this option to avoid clock off.
>
> Change-Id: Id841f58e9d7fb3656511072b3eb14d0d355e2dd5
Sorry I've found a Change-ID tag here,
I'll send patch v3.
> Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
> ---
> Changes for v2:
> - Rename "mediatek,keep-clock-on" to "mediatek,str-clock-on" which implies
> this option related to STR functions.
> - After discussion with Chunfeng, resend dt-bindings descritption based on
> mediatek,mtk-xhci.txt instead of yaml format.
>
> .../devicetree/bindings/usb/mediatek,mtk-xhci.txt | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt
> index 42d8814..fc93bcf 100644
> --- a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt
> +++ b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.txt
> @@ -37,6 +37,9 @@ Required properties:
>
> Optional properties:
> - wakeup-source : enable USB remote wakeup;
> + - mediatek,str-clock-on: Keep clock on during system suspend and resume.
> + Some platform will flush register settings if clock has been disabled
> + when system is suspended.
> - mediatek,syscon-wakeup : phandle to syscon used to access the register
> of the USB wakeup glue layer between xHCI and SPM; it depends on
> "wakeup-source", and has two arguments:
Thanks
Macpaul Lin
next prev parent reply other threads:[~2020-11-06 9:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-02 7:18 [PATCH 1/2] dt-bindings: usb: mediatek,mtk-xhci: add keep-clock-on Macpaul Lin
2020-11-02 7:18 ` [PATCH 2/2] usb: host: XHCI: xhci-mtk.c: support mediatek,keep-clock-on Macpaul Lin
2020-11-03 3:01 ` [PATCH 1/2] dt-bindings: usb: mediatek,mtk-xhci: add keep-clock-on Chunfeng Yun
2020-11-04 22:39 ` Rob Herring
2020-11-06 9:29 ` Macpaul Lin
2020-11-06 9:46 ` [PATCH v2 1/2] dt-bindings: usb: mediatek,mtk-xhci: add str-clock-on Macpaul Lin
2020-11-06 9:46 ` [PATCH v2 2/2] usb: host: XHCI: xhci-mtk.c: support mediatek,str-clock-on Macpaul Lin
2020-11-06 9:58 ` Macpaul Lin [this message]
2020-11-06 10:21 ` [PATCH v3 1/2] dt-bindings: usb: mediatek,mtk-xhci: add str-clock-on Macpaul Lin
2020-11-06 10:21 ` [PATCH v3 2/2] usb: host: XHCI: xhci-mtk.c: support mediatek,str-clock-on Macpaul Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1604656720.24301.24.camel@mtkswgap22 \
--to=macpaul.lin@mediatek.com \
--cc=Chunfeng.Yun@mediatek.com \
--cc=Eddie.Hung@mediatek.com \
--cc=ainge.hsu@mediatek.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=macpaul@gmail.com \
--cc=mathias.nyman@intel.com \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox