public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Bhaumik Bhatt <bbhatt@codeaurora.org>
To: manivannan.sadhasivam@linaro.org
Cc: linux-arm-msm@vger.kernel.org, hemantk@codeaurora.org,
	jhugo@codeaurora.org, linux-kernel@vger.kernel.org,
	Bhaumik Bhatt <bbhatt@codeaurora.org>
Subject: [PATCH v2 1/6] bus: mhi: core: Remove unnecessary counter from mhi_firmware_copy()
Date: Fri,  6 Nov 2020 09:44:45 -0800	[thread overview]
Message-ID: <1604684690-31065-2-git-send-email-bbhatt@codeaurora.org> (raw)
In-Reply-To: <1604684690-31065-1-git-send-email-bbhatt@codeaurora.org>

There is an extra 'i' counter in the mhi_firmware_copy() function
which is unused. Remove it to clean-up code and reduce stack
space as well as improve efficiency of the function.

Fixes: cd457afb1667 ("bus: mhi: core: Add support for downloading firmware over BHIe")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Bhaumik Bhatt <bbhatt@codeaurora.org>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
 drivers/bus/mhi/core/boot.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/bus/mhi/core/boot.c b/drivers/bus/mhi/core/boot.c
index 24422f5..6b6fd96 100644
--- a/drivers/bus/mhi/core/boot.c
+++ b/drivers/bus/mhi/core/boot.c
@@ -365,7 +365,6 @@ static void mhi_firmware_copy(struct mhi_controller *mhi_cntrl,
 	size_t remainder = firmware->size;
 	size_t to_cpy;
 	const u8 *buf = firmware->data;
-	int i = 0;
 	struct mhi_buf *mhi_buf = img_info->mhi_buf;
 	struct bhi_vec_entry *bhi_vec = img_info->bhi_vec;
 
@@ -377,7 +376,6 @@ static void mhi_firmware_copy(struct mhi_controller *mhi_cntrl,
 
 		buf += to_cpy;
 		remainder -= to_cpy;
-		i++;
 		bhi_vec++;
 		mhi_buf++;
 	}
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project


  reply	other threads:[~2020-11-06 17:45 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-06 17:44 [PATCH v2 0/6] Minor bug fixes and clean-up for MHI host driver Bhaumik Bhatt
2020-11-06 17:44 ` Bhaumik Bhatt [this message]
2020-11-06 17:44 ` [PATCH v2 2/6] bus: mhi: core: Add missing EXPORT_SYMBOL for mhi_get_mhi_state() Bhaumik Bhatt
2020-11-06 17:44 ` [PATCH v2 3/6] bus: mhi: core: Expose mhi_get_exec_env() API for controllers Bhaumik Bhatt
2020-11-09 12:06   ` Manivannan Sadhasivam
2020-11-06 17:44 ` [PATCH v2 4/6] bus: mhi: core: Remove unused mhi_fw_load_worker() declaration Bhaumik Bhatt
2020-11-06 17:44 ` [PATCH v2 5/6] bus: mhi: core: Rename RDDM download function to use proper words Bhaumik Bhatt
2020-11-06 17:44 ` [PATCH v2 6/6] bus: mhi: core: Skip RDDM download for unknown execution environment Bhaumik Bhatt
2020-11-09 12:08   ` Manivannan Sadhasivam
2020-11-09 13:30 ` [PATCH v2 0/6] Minor bug fixes and clean-up for MHI host driver Manivannan Sadhasivam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1604684690-31065-2-git-send-email-bbhatt@codeaurora.org \
    --to=bbhatt@codeaurora.org \
    --cc=hemantk@codeaurora.org \
    --cc=jhugo@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox