From: Stanley Chu <stanley.chu@mediatek.com>
To: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <linux-scsi@vger.kernel.org>,
<kernel-team@android.com>, Leo Liou <leoliou@google.com>
Subject: Re: [PATCH] scsi: ufs: show lba and length for unmap commands
Date: Fri, 13 Nov 2020 09:10:39 +0800 [thread overview]
Message-ID: <1605229839.32073.8.camel@mtkswgap22> (raw)
In-Reply-To: <20201112165950.518952-1-jaegeuk@kernel.org>
Hi,
On Thu, 2020-11-12 at 08:59 -0800, Jaegeuk Kim wrote:
> From: Leo Liou <leoliou@google.com>
>
> We have lba and length for unmap commands.
>
> Signed-off-by: Leo Liou <leoliou@google.com>
> ---
> drivers/scsi/ufs/ufshcd.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index 86c8dee01ca9..dba3ee307307 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -376,6 +376,11 @@ static void ufshcd_add_command_trace(struct ufs_hba *hba,
> lrbp->ucd_req_ptr->sc.exp_data_transfer_len);
> if (opcode == WRITE_10)
> group_id = lrbp->cmd->cmnd[6];
> + } else if (opcode == UNMAP) {
> + if (cmd->request) {
> + lba = scsi_get_lba(cmd);
> + transfer_len = blk_rq_bytes(cmd->request);
> + }
Nitpicking: Perhaps we could unify the method of obtaining both lba and
transfer_len for all READ/WRITE/UNMAP commands?
Reviewed-by: Stanley Chu <stanley.chu@mediatek.com>
> }
> }
>
next prev parent reply other threads:[~2020-11-13 1:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-12 16:59 [PATCH] scsi: ufs: show lba and length for unmap commands Jaegeuk Kim
2020-11-13 1:10 ` Stanley Chu [this message]
2020-11-17 3:40 ` Martin K. Petersen
2020-11-17 17:04 ` Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1605229839.32073.8.camel@mtkswgap22 \
--to=stanley.chu@mediatek.com \
--cc=jaegeuk@kernel.org \
--cc=kernel-team@android.com \
--cc=leoliou@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox