From: Masami Hiramatsu <mhiramat@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Cc: Chen Yu <yu.c.chen@intel.com>, Chen Yu <yu.chen.surf@gmail.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>
Subject: [PATCH 0/2] tools/bootconfig: Align the bootconfig applied initrd
Date: Tue, 17 Nov 2020 00:05:43 +0900 [thread overview]
Message-ID: <160553914311.90558.426504572691633862.stgit@devnote2> (raw)
Hi,
This updates bootconfig tool to align the total size of initrd +
bootconfig to 4. To adjust the file size, the bootconfig tool
adds padding null characters in between the boot configuration
data and the footer.
This series include Documentation update. The changing points are
- The bootconfig applied initrd image size is aligned to 4.
- To insert the padding null ('\0') bytes, the size in the footer
can be bigger than the actual bootconfig file size.
- But the max size of the boot configuration file is same, because
the max size doesn't include the last null characters.
For this version I decided to keep 4 bytes aligned rather than
longer size. It will be easy to expand it to e.g. 32 bytes (in this
series, we just need to update 3 locations of the code), but I
couldn't find any reason to expand it. Only I could found was
that the grub can align the filesize to 4, and U-Boot/EDK2 will
not change it. So I couldn't say what is the best size.
Anyway, I updated the documentation too, which clearly says that
the above changing points, and if the bootloader pass the wrong
size, kernel will not find bootconfig from the initrd.
Thank you,
---
Masami Hiramatsu (2):
tools/bootconfig: Align the bootconfig applied initrd image size to 4
Documentation: bootconfig: Update file format on initrd image
Documentation/admin-guide/bootconfig.rst | 18 ++++++++++++----
include/linux/bootconfig.h | 1 +
tools/bootconfig/main.c | 33 +++++++++++++++++++++++++-----
tools/bootconfig/test-bootconfig.sh | 6 +++++
4 files changed, 47 insertions(+), 11 deletions(-)
--
Masami Hiramatsu (Linaro) <mhiramat@kernel.org>
next reply other threads:[~2020-11-16 15:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-16 15:05 Masami Hiramatsu [this message]
2020-11-16 15:05 ` [PATCH 1/2] tools/bootconfig: Align the bootconfig applied initrd image size to 4 Masami Hiramatsu
2020-11-16 15:51 ` Masami Hiramatsu
2020-11-16 23:34 ` Woody Suwalski
2020-11-16 15:06 ` [PATCH 2/2] Documentation: bootconfig: Update file format on initrd image Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=160553914311.90558.426504572691633862.stgit@devnote2 \
--to=mhiramat@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rostedt@goodmis.org \
--cc=torvalds@linux-foundation.org \
--cc=yu.c.chen@intel.com \
--cc=yu.chen.surf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox