* [PATCH net] cx82310_eth: fix error return code in cx82310_bind()
@ 2020-11-13 6:07 Zhang Changzhong
2020-11-16 23:30 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Zhang Changzhong @ 2020-11-13 6:07 UTC (permalink / raw)
To: davem, kuba, linux; +Cc: linux-usb, netdev, linux-kernel
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.
Fixes: ca139d76b0d9 ("cx82310_eth: re-enable ethernet mode after router reboot")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
---
drivers/net/usb/cx82310_eth.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/usb/cx82310_eth.c b/drivers/net/usb/cx82310_eth.c
index ca89d82..c4568a4 100644
--- a/drivers/net/usb/cx82310_eth.c
+++ b/drivers/net/usb/cx82310_eth.c
@@ -197,7 +197,8 @@ static int cx82310_bind(struct usbnet *dev, struct usb_interface *intf)
}
/* enable ethernet mode (?) */
- if (cx82310_enable_ethernet(dev))
+ ret = cx82310_enable_ethernet(dev);
+ if (ret)
goto err;
/* get the MAC address */
--
2.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net] cx82310_eth: fix error return code in cx82310_bind()
2020-11-13 6:07 [PATCH net] cx82310_eth: fix error return code in cx82310_bind() Zhang Changzhong
@ 2020-11-16 23:30 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2020-11-16 23:30 UTC (permalink / raw)
To: Zhang Changzhong; +Cc: davem, kuba, linux, linux-usb, netdev, linux-kernel
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Fri, 13 Nov 2020 14:07:07 +0800 you wrote:
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Fixes: ca139d76b0d9 ("cx82310_eth: re-enable ethernet mode after router reboot")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
>
> [...]
Here is the summary with links:
- [net] cx82310_eth: fix error return code in cx82310_bind()
https://git.kernel.org/netdev/net/c/cfbaa8b33e02
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-16 23:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-13 6:07 [PATCH net] cx82310_eth: fix error return code in cx82310_bind() Zhang Changzhong
2020-11-16 23:30 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox