From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751359AbcFNLHl (ORCPT ); Tue, 14 Jun 2016 07:07:41 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:61121 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751150AbcFNLHj (ORCPT ); Tue, 14 Jun 2016 07:07:39 -0400 From: Arnd Bergmann To: kbuild test robot Cc: Ben Dooks , kbuild-all@01.org, linux-kernel@lists.codethink.co.uk, Greg Kroah-Hartman , Philipp Zabel , Alan Stern , Peter Chen , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] USB: core: fix missing include Date: Tue, 14 Jun 2016 13:08:08 +0200 Message-ID: <16060867.1nFmu0b2lQ@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <201606080333.vfFKvIIV%fengguang.wu@intel.com> References: <201606080333.vfFKvIIV%fengguang.wu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:eejrl9ti+lmkTGvi6fKJyWff3Slq02LSwrmagSAMA1clXHL4SRk GcvRl8qs1QnhHQ7IrYIab/ty1mYpNopjTUlHBUYBHRtKaAbNhOHOEauurJ6NPupX6ZQQMK0 FVHoMXb2/+Dm3lEAzregvOIC6EMWVbFsj1Pu0jif613rGi+3vjAKtGKkmFhOBbDgGujR3ZE sh4AhkrUNG0hJbzYVj6jA== X-UI-Out-Filterresults: notjunk:1;V01:K0:XFhXNR5bfsY=:ggCUrRBVsA0kE/TSo2xg4w svnyI/goFgAvg1fBu5/NJ9s3mZMYE2PmVd6tqvUgiMY952WgZObqMPfqI4FZ1UvUq1COZBXZf e2qyISndXsZtWAjJBTxvT5N/ybfgAyIlzERcMA/8Rr/Wd8UFMblFw9f85N51xZ5TRMAGWQQNM IuKQ4KxSktE41UIMvPRsGFtkeYyPuv58lQbm7ACSeDkYtD5/bD/K4/AiWoO+bC/ww72E1GIJs 8VpWBRFDZamSbxSN8pUEAPXXlvLCvHywcscqdCEY+5puO7amWbaqxaXo9A2T6QwhWKdtEoOVU AtmkCmFZZBe285PVsm36qbHD/zy2ZjC+mbCQR8xHVQ1X+2YhXSmaefCmSBQDN4X+mNhnXtKHy hngvAh5RC7/Y7KUXJ0QeWo9Mi5+p40M5ssOT3yn5pMPDi6zsNxR69ONHL4GnyqrDJVEHOimBT JBeMd7P+4bRjKIDgpq2EpeCF4rVc8Uka4oPsKShPmytGc3F5FXIPQvDMTv+xGVEDFWCjQZEMm r7SxLU4QHsyq4tCJQkf1G+gpd1wHp0GuTNmvg97fxQGvHs3MzV1OnOc0SDdI6GVpvZcU8TcCx V+oFmFqozqTt049qh6ixU/mWW20R4WOiTpMzHbsQUxBv99w7K8ulAwgP8uOMsvTj4TIsm2hHo 6y8bG36XsUwTODmqZBmt8FV4p6YMPUCqijPD7udHSsmnKua9qWpLsxEq/x58jJcr4jQ/fPvRG X7J3HiR1YvZ7fUZf Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, June 8, 2016 3:04:27 AM CEST kbuild test robot wrote: > >> drivers/usb/core/of.c:32:21: error: redefinition of 'usb_of_get_child_node' > struct device_node *usb_of_get_child_node(struct device_node *parent, > ^~~~~~~~~~~~~~~~~~~~~ > In file included from drivers/usb/core/of.c:21:0: > include/linux/usb/of.h:36:35: note: previous definition of 'usb_of_get_child_node' was here > static inline struct device_node *usb_of_get_child_node > ^~~~~~~~~~~~~~~~~~~~~ > > vim +/usb_of_get_child_node +32 drivers/usb/core/of.c > > 69bec725 Peter Chen 2016-02-19 26 * @portnum: the port number which device is connecting > 69bec725 Peter Chen 2016-02-19 27 * > 69bec725 Peter Chen 2016-02-19 28 * Find the node from device tree according to its port number. > 69bec725 Peter Chen 2016-02-19 29 * > 69bec725 Peter Chen 2016-02-19 30 * Return: On success, a pointer to the device node, %NULL on failure. > 69bec725 Peter Chen 2016-02-19 31 */ > 69bec725 Peter Chen 2016-02-19 @32 struct device_node *usb_of_get_child_node(struct device_node *parent, > 69bec725 Peter Chen 2016-02-19 33 int portnum) > 69bec725 Peter Chen 2016-02-19 34 { > 69bec725 Peter Chen 2016-02-19 35 struct device_node *node; > > I think what we want here is to make the compilation of of.o conditional on CONFIG_OF, so we get only one of the two definitions. Arnd