Re: [PATCH] libata: Ignore spurious PHY events on LPM policy change

Gabriele Mazzotta
2015-04-25T17:57:26Z

On Saturday 25 April 2015 11:37:51 Tejun Heo wrote:
> I thought more about it and it's weird to have ATA_LFLAG_CHANGED and
> last_lpm_change timestamp in libata core side and then open-code the
> actual logic in ahci. How about implementing a generic helper, say,
> bool sata_lpm_ignore_phy_events(link) in libata core and use it in
> specific drivers? It can test both the current lpm_policy and the
> timeout (preferably a separate patch to introduce the function and
> factor out lpm policy testing).

I agree. I'm now going to send the revised patches, thanks for all
the suggestions.

Gabriele