Re: [PATCH] drivers: qcom: rpmh-rsc: Do not read back the register write on trigger

Doug Anderson
2020-12-03T21:17:02Z

Hi,

On Tue, Nov 24, 2020 at 1:53 AM Maulik Shah <mkshah@codeaurora.org> wrote:
>
> From: Lina Iyer <ilina@codeaurora.org>
>
> When triggering a TCS to send its contents, reading back the trigger
> value may return an incorrect value. That is because, writing the
> trigger may raise an interrupt which could be handled immediately and
> the trigger value could be reset in the interrupt handler.
>
> A write_tcs_reg_sync() would read back the value that is written and try
> to match it to the value written to ensure that the value is written,
> but if that value is different, we may see false error for same.
>
> Signed-off-by: Lina Iyer <ilina@codeaurora.org>
> Signed-off-by: Maulik Shah <mkshah@codeaurora.org>
> ---
> drivers/soc/qcom/rpmh-rsc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Fixes: 658628e7ef78 ("drivers: qcom: rpmh-rsc: add RPMH controller for
QCOM SoCs")
Signed-off-by: Douglas Anderson <dianders@chromium.org>