From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758273AbcGKKVh (ORCPT ); Mon, 11 Jul 2016 06:21:37 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:63093 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758091AbcGKKVf convert rfc822-to-8bit (ORCPT ); Mon, 11 Jul 2016 06:21:35 -0400 From: Arnd Bergmann To: Wan Zongshun Cc: linux-arm-kernel@lists.infradead.org, Russell King , devicetree@vger.kernel.org, linux-clk@vger.kernel.org, jason@lakedaemon.net, Daniel Lezcano , linux-kernel@vger.kernel.org, p.zabel@pengutronix.de, Thomas Gleixner , Wan Zongshun Subject: Re: [PATCH v2 06/10] soc: Add SoC specific driver support for nuc900 Date: Mon, 11 Jul 2016 12:24:21 +0200 Message-ID: <1606219.BzcByuFgJm@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <578361B5.7010803@iommu.org> References: <1468135649-19980-1-git-send-email-vw@iommu.org> <4765191.NGpMC1JR46@wuerfel> <578361B5.7010803@iommu.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K0:uy+abRxSecaAoqDIEPFF5Wad563Qc46WFXXieQ1EnOZBOF04FrX bUNn3vKZ490kyzkHPRCayTJB27dhHrYz6uf/2knFTD0HR1Wz7eQDKEtTWUvL+grBFNQZpLE afcTnGk0xb2WznthtrB/8ozAVyY0Z3feJg3+gY9Cqm6ICRSexXF6RUX5SiX7m8ZBxus87AF 3c8xhKeSXP+m5wkinoF/A== X-UI-Out-Filterresults: notjunk:1;V01:K0:7btnd6rROUI=:LsHHHcbM4TbtaymtIchVgl d0iRnNO8o1Zn427tlKyhC27EYvBfiUfuAwyHh/zOTYPunSsmrXThpCIBJ1VBBWKG6fu1a8sZL KdvX7tQ1fMiVlC7dpdtiWcLsa6XB3N9V/Ku1o7eryum2KeoV5YIrq8Mx2Q/ihY0nrtE0Al75w izU0p3+I3v9EGninLykq4/EeY3FXxxR3bqBjClzTU+Jc/ffmEv7PqPGxIdrdeeYH0IUff4GER sm22hlaxPr2DEahbRiHGqO7KtBHWGM5C1xj+JdkyMfghWlhNV/K7agctyiRNSDYQ9T0SZgl2W GfYphMtwbvii3cbD7hU2iEhbcga220Wcr6M1j6oZ1wmzorT1iij4K4SaEmaDfjYG4MmbGqpTl FCB8jKSNh+yzrvH4PwgWRFOwnLzM/N7ux+UeW/HvfRO91O51JYlU4r6ONIJvZhGTNQXOXlHAZ 2s4AUEVhdlF2iASHRCon78GMvMQ+tJaKrOwzDSYZV4nrI3hwHhESHmfcWTvEzQ75xPrMZNpUp awSDEx2HTy0nqUWs5AV7t537U9v6z03oKFkH+i0xZ3SsCBTDggRD9uk84VXgQBIiHgigBdBZF 3bEOPdGd5YoDM2bwOzNeiRwwUSHPFBP5iOauuyHLy78aYqHqat+sBFuGFWz1QfKkY9pKuVnx1 r5mMvz+HlnVBaWZ4cxhavSjvX0fb8yt8NLYzqiWccj13zQM2JmHdnMCewjIoQ6M6MnAWcDpkL 9A8+2lQNR4EzLZvw Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday, July 11, 2016 5:07:01 PM CEST Wan Zongshun wrote: > > On 2016年07月11日 16:03, Arnd Bergmann wrote: > > On Sunday, July 10, 2016 3:27:26 PM CEST Wan Zongshun wrote: > >> + ret = of_property_read_string(np, "compatible", &soc_dev_attr->soc_id); > >> + if (ret) > >> return -EINVAL; > >> + > >> + soc_dev_attr->machine = "NUC900EVB"; > >> + soc_dev_attr->family = "NUC900"; > >> + soc_dev = soc_device_register(soc_dev_attr); > >> + if (IS_ERR(soc_dev)) { > >> + kfree(soc_dev_attr); > >> + return -ENODEV; > >> + } > >> + > >> + ret = regmap_read(syscon_regmap, GCR_CHIPID, &nuc900_chipid); > >> + if (ret) > >> + return -ENODEV; > >> + > >> + device_create_file(soc_device_to_device(soc_dev), &nuc900_chipid_attr); > >> + device_create_file(soc_device_to_device(soc_dev), &nuc900_version_attr); > >> + > >> + dev_info(&pdev->dev, "Nuvoton Chip ID: 0x%x, Version ID:0x%x\n", > >> + nuc900_chipid & GCR_CHIPID_MASK, > >> + (nuc900_chipid >> 24) & 0xff); > > > > I'm still a bit unsure about the set of attributes here. > > > > - The "soc_id" is read from the device tree from the field that contains > > the board name, I think for consistency you should try to map the > > GCR_CHIPID to the name of the SoC and assign that here > > I will try to get chipid and map it to soc name like: “nuc970”, "nuc910". > > And I will set this soc name to soc_id, ok? Ok. > > - The "machine" is hardcoded to "NUC900EVB", which in turn looks like > > a particular board but not the one you are running on. Maybe read > > that from the DT instead? > > Should I read nuc970-evb.dts's "model" or "compatible" properties? I think "model" is best here, but see what the others do. Arnd