* [PATCH] drm: rcar-du: Use drm_dev_put
@ 2018-04-25 12:10 Vaishali Thakkar
2018-04-25 13:32 ` Laurent Pinchart
0 siblings, 1 reply; 4+ messages in thread
From: Vaishali Thakkar @ 2018-04-25 12:10 UTC (permalink / raw)
To: laurent.pinchart
Cc: airlied, dri-devel, linux-renesas-soc, linux-kernel,
Vaishali Thakkar
As specified in drm_drv.c, drm_dev_unref is a compatibility alias
for drm_dev_put and shouldn't be used in new code. So, use
drm_dev_put instead.
Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
---
drivers/gpu/drm/rcar-du/rcar_du_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
index 05745e86d73e..418a80e6b2f4 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
@@ -378,7 +378,7 @@ static int rcar_du_remove(struct platform_device *pdev)
drm_kms_helper_poll_fini(ddev);
drm_mode_config_cleanup(ddev);
- drm_dev_unref(ddev);
+ drm_dev_put(ddev);
return 0;
}
--
2.14.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm: rcar-du: Use drm_dev_put
2018-04-25 12:10 [PATCH] drm: rcar-du: Use drm_dev_put Vaishali Thakkar
@ 2018-04-25 13:32 ` Laurent Pinchart
2018-04-25 13:42 ` Vaishali Thakkar
0 siblings, 1 reply; 4+ messages in thread
From: Laurent Pinchart @ 2018-04-25 13:32 UTC (permalink / raw)
To: Vaishali Thakkar; +Cc: airlied, dri-devel, linux-renesas-soc, linux-kernel
Hi Vaishali,
Thank you for the patch.
On Wednesday, 25 April 2018 15:10:36 EEST Vaishali Thakkar wrote:
> As specified in drm_drv.c, drm_dev_unref is a compatibility alias
> for drm_dev_put and shouldn't be used in new code. So, use
> drm_dev_put instead.
This looks good to me. However, how about taking it one step further and mass-
patching all drivers to use drm_dev_put() ? We could then remove
drm_dev_unref() completely.
> Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
> ---
> drivers/gpu/drm/rcar-du/rcar_du_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index 05745e86d73e..418a80e6b2f4
> 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> @@ -378,7 +378,7 @@ static int rcar_du_remove(struct platform_device *pdev)
> drm_kms_helper_poll_fini(ddev);
> drm_mode_config_cleanup(ddev);
>
> - drm_dev_unref(ddev);
> + drm_dev_put(ddev);
>
> return 0;
> }
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm: rcar-du: Use drm_dev_put
2018-04-25 13:32 ` Laurent Pinchart
@ 2018-04-25 13:42 ` Vaishali Thakkar
2018-04-25 13:44 ` Laurent Pinchart
0 siblings, 1 reply; 4+ messages in thread
From: Vaishali Thakkar @ 2018-04-25 13:42 UTC (permalink / raw)
To: Laurent Pinchart
Cc: airlied, dri-devel, linux-renesas-soc, Linux Kernel Mailing List
On Wed, Apr 25, 2018 at 7:02 PM, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> Hi Vaishali,
>
> Thank you for the patch.
>
> On Wednesday, 25 April 2018 15:10:36 EEST Vaishali Thakkar wrote:
>> As specified in drm_drv.c, drm_dev_unref is a compatibility alias
>> for drm_dev_put and shouldn't be used in new code. So, use
>> drm_dev_put instead.
>
> This looks good to me. However, how about taking it one step further and mass-
> patching all drivers to use drm_dev_put() ? We could then remove
> drm_dev_unref() completely.
Sure thing! Do you want me to fold this patch in that patchset or will you be
fine with applying this separately?
>> Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
>> ---
>> drivers/gpu/drm/rcar-du/rcar_du_drv.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
>> b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index 05745e86d73e..418a80e6b2f4
>> 100644
>> --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
>> +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
>> @@ -378,7 +378,7 @@ static int rcar_du_remove(struct platform_device *pdev)
>> drm_kms_helper_poll_fini(ddev);
>> drm_mode_config_cleanup(ddev);
>>
>> - drm_dev_unref(ddev);
>> + drm_dev_put(ddev);
>>
>> return 0;
>> }
>
> --
> Regards,
>
> Laurent Pinchart
>
>
>
--
Vaishali
http://vaishalithakkar.in/
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm: rcar-du: Use drm_dev_put
2018-04-25 13:42 ` Vaishali Thakkar
@ 2018-04-25 13:44 ` Laurent Pinchart
0 siblings, 0 replies; 4+ messages in thread
From: Laurent Pinchart @ 2018-04-25 13:44 UTC (permalink / raw)
To: Vaishali Thakkar
Cc: airlied, dri-devel, linux-renesas-soc, Linux Kernel Mailing List
Hi Vaishali,
On Wednesday, 25 April 2018 16:42:59 EEST Vaishali Thakkar wrote:
> On Wed, Apr 25, 2018 at 7:02 PM, Laurent Pinchart wrote:
> > On Wednesday, 25 April 2018 15:10:36 EEST Vaishali Thakkar wrote:
> >> As specified in drm_drv.c, drm_dev_unref is a compatibility alias
> >> for drm_dev_put and shouldn't be used in new code. So, use
> >> drm_dev_put instead.
> >
> > This looks good to me. However, how about taking it one step further and
> > mass- patching all drivers to use drm_dev_put() ? We could then remove
> > drm_dev_unref() completely.
>
> Sure thing! Do you want me to fold this patch in that patchset or will you
> be fine with applying this separately?
I don't think we should split the change in one patch per driver, so if you
send a single patch (to be applied through drm-misc) I think it would make
sense to fold this change in.
> >> Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
> >> ---
> >>
> >> drivers/gpu/drm/rcar-du/rcar_du_drv.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> >> b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index 05745e86d73e..418a80e6b2f4
> >> 100644
> >> --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> >> +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> >> @@ -378,7 +378,7 @@ static int rcar_du_remove(struct platform_device
> >> *pdev)
> >> drm_kms_helper_poll_fini(ddev);
> >> drm_mode_config_cleanup(ddev);
> >>
> >> - drm_dev_unref(ddev);
> >> + drm_dev_put(ddev);
> >> return 0;
> >> }
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-04-25 13:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-25 12:10 [PATCH] drm: rcar-du: Use drm_dev_put Vaishali Thakkar
2018-04-25 13:32 ` Laurent Pinchart
2018-04-25 13:42 ` Vaishali Thakkar
2018-04-25 13:44 ` Laurent Pinchart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox