Re: [PATCH v3 5/8] regulator: mt6359: Add support for MT6359 regulator

Mark Brown
2020-12-15T11:57:50Z

[-- Attachment #1: Type: text/plain, Size: 709 bytes --]

On Tue, Dec 15, 2020 at 05:23:08PM +0800, Hsin-hsiung Wang wrote:
> On Tue, 2020-11-24 at 17:07 +0000, Mark Brown wrote:

> > This looks like it could just be regmap_get_voltage_sel_regmap()?
> > Otherwise the driver looks good.

> Thanks for the review.
> MT6359 regulator has sel_reg and status_reg, so we use
> mt6359_get_linear_voltage_sel for status_reg instead of
> regmap_get_voltage_sel_regmap() which uses sel_reg.

Is the selector register not readable? In general the rule is that the
get should be reporting what was configured, the actual status should be
reported separately if it can be read separately. We don't currently
have a mechanism for doing that with voltage but one could be added.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]