From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751817AbcILQBO (ORCPT ); Mon, 12 Sep 2016 12:01:14 -0400 Received: from mail.suteba.org.ar ([200.16.134.105]:47788 "EHLO mail.suteba.org.ar" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750934AbcILQBM (ORCPT ); Mon, 12 Sep 2016 12:01:12 -0400 X-Qmail-Scanner-Diagnostics: from 10.0.1.30 by mail (envelope-from , uid 1001) with qmail-scanner-2.11 (mhr: 1.0. clamdscan: 0.98.7/21419. Clear:RC:1(10.0.1.30):. Processed in 0.022178 secs); 12 Sep 2016 16:01:07 -0000 From: Matias Mucciolo To: Ian Abbott Cc: H Hartley Sweeten , Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH resend] staging: comedi: comedi_fops: coding style fixes Date: Mon, 12 Sep 2016 13:01:01 -0300 Message-ID: <1608130.74sP92kvXV@varitech> Organization: SUTEBA User-Agent: KMail/4.14.1 (Linux/4.3.0-0.bpo.1-amd64; KDE/4.14.2; x86_64; ; ) In-Reply-To: <40f52f01-4f57-3f39-42f2-081f4619e656@mev.co.uk> References: <4304487.jBCdsPv9LF@varitech> <40f52f01-4f57-3f39-42f2-081f4619e656@mev.co.uk> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ian yes its a coding style issue(checkpatch.pl WARN) and reference: https://lwn.net/Articles/696229/ (sorry about the noise.) -- Matias Mucciolo Area de Infraestructura. Piedras 737 C.A.B.A SUTEBA On Monday 12 September 2016 16:52:59 Ian Abbott wrote: > On 12/09/16 14:18, Matias Mucciolo wrote: > > > > From: Matias Mucciolo > > > > - Fixed coding style in comedi_fops.c Symbolic to octal permission. > > > > Signed-off-by: Matias Mucciolo > > --- > > drivers/staging/comedi/comedi_fops.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c > > index 1999eed..bf922ea 100644 > > --- a/drivers/staging/comedi/comedi_fops.c > > +++ b/drivers/staging/comedi/comedi_fops.c > > @@ -81,20 +81,20 @@ struct comedi_file { > > (COMEDI_NUM_MINORS - COMEDI_NUM_BOARD_MINORS) > > > > static int comedi_num_legacy_minors; > > -module_param(comedi_num_legacy_minors, int, S_IRUGO); > > +module_param(comedi_num_legacy_minors, int, 0444); > > MODULE_PARM_DESC(comedi_num_legacy_minors, > > "number of comedi minor devices to reserve for non-auto-configured devices (default 0)" > > ); > > > > unsigned int comedi_default_buf_size_kb = CONFIG_COMEDI_DEFAULT_BUF_SIZE_KB; > > -module_param(comedi_default_buf_size_kb, uint, S_IRUGO | S_IWUSR); > > +module_param(comedi_default_buf_size_kb, uint, 0644); > > MODULE_PARM_DESC(comedi_default_buf_size_kb, > > "default asynchronous buffer size in KiB (default " > > __MODULE_STRING(CONFIG_COMEDI_DEFAULT_BUF_SIZE_KB) ")"); > > > > unsigned int comedi_default_buf_maxsize_kb > > = CONFIG_COMEDI_DEFAULT_BUF_MAXSIZE_KB; > > -module_param(comedi_default_buf_maxsize_kb, uint, S_IRUGO | S_IWUSR); > > +module_param(comedi_default_buf_maxsize_kb, uint, 0644); > > MODULE_PARM_DESC(comedi_default_buf_maxsize_kb, > > "default maximum size of asynchronous buffer in KiB (default " > > __MODULE_STRING(CONFIG_COMEDI_DEFAULT_BUF_MAXSIZE_KB) ")"); > > > > In my review of the earlier patch, I said I was fine with the octal > constants, but on reflection, I'm not sure it's worth changing them just > for the hell of it. We'd probably get a patch from someone else later > to change it back to symbolic constants. Is there an actual coding > style issue, or is this just a personal preference? > > -- > -=( Ian Abbott @ MEV Ltd. E-mail: )=- > -=( Web: http://www.mev.co.uk/ )=-