From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933150AbcIALAK (ORCPT <rfc822;w@1wt.eu>);
        Thu, 1 Sep 2016 07:00:10 -0400
Received: from mailout4.samsung.com ([203.254.224.34]:51565 "EHLO
        mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1754787AbcIAK7x (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 1 Sep 2016 06:59:53 -0400
X-AuditID: cbfee61a-f78ff6d000001462-98-57c80a216204
From: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Tomasz Figa <tomasz.figa@gmail.com>,
        Krzysztof Kozlowski <krzk@kernel.org>,
        Sylwester Nawrocki <s.nawrocki@samsung.com>,
        Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
        Kukjin Kim <kgene@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
        javier@osg.samsung.com, Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH 5/6] ARM: dts: s3c2416: Use macros for pinctrl configuration
Date: Thu, 01 Sep 2016 12:59:41 +0200
Message-id: <1608454.1ZuTJsprje@amdc1976>
User-Agent: KMail/4.13.3 (Linux/3.13.0-79-generic; KDE/4.13.3; x86_64; ; )
In-reply-to: <1472721715-2833-6-git-send-email-k.kozlowski@samsung.com>
References: <1472721715-2833-1-git-send-email-k.kozlowski@samsung.com>
 <1472721715-2833-6-git-send-email-k.kozlowski@samsung.com>
MIME-version: 1.0
Content-transfer-encoding: 7Bit
Content-type: text/plain; charset=us-ascii
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprGIsWRmVeSWpSXmKPExsVy+t9jQV1FrhPhBofPylr8nXSM3WL+kXOs
        Fm/ermGyeP3C0KL/8Wtmi/PnN7BbTPmznMli0+NrrBaXd81hs5hxfh+TxdLrF5ksWvceYbc4
        /Kad1WLVrj+MDnwea+atYfT4/WsSo8fOWXfZPTat6mTzuHNtD5vH5iX1Hlv6gUJ9W1Yxenze
        JBfAGcVlk5Kak1mWWqRvl8CV8WHnbZaCP5wVf578ZWxgnMzRxcjJISFgIjFl+WEWCFtM4sK9
        9WxdjFwcQgKzGCWaZq5jhnC+MkpMu/KFFaSKTcBKYmL7KkYQW0TAUOLg7u1MIEXMAheZJZpP
        3GUCSQgLBEhMaf3BBmKzCKhKTNnWzA5i8wpoSrQ8ugZmiwp4SfRsfwQ2iFPAXeLq5Z2sENua
        GSWmL7zIAtEgKPFj8j0wm1lAXmLf/qmsELaWxPqdx5kmMAIdilA2C0nZLCRlCxiZVzFKpBYk
        FxQnpeca5qWW6xUn5haX5qXrJefnbmIEx9YzqR2MB3e5H2IU4GBU4uH1CjweLsSaWFZcmXuI
        UYKDWUmE9w7riXAh3pTEyqrUovz4otKc1OJDjNIcLErivI//rwsTEkhPLEnNTk0tSC2CyTJx
        cEo1MNqeM5nx4a+HxAfdSQmf+hO/O/JMSsmduN7t2OH9KiseyR9a+sNaT2jnkudP564+cfEN
        F9ey7lfbEn+bWbva9r69ZPJWXK1i1sV0gxecVe/K/gtxr6rSdZPj//to3Y3z3K5XT/ZeNM+T
        M5j15M00965z/9Qt8mo8GF/vvjVf7UtazFLtGWcYF/UrsRRnJBpqMRcVJwIAmD2Ou6kCAAA=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Hi,

On Thursday, September 01, 2016 11:21:54 AM Krzysztof Kozlowski wrote:
> Usage of DTS macros instead of hard-coded numbers makes code easier
> to read.  One does not have to remember which value means pull-up/down
> or specific driver strength.
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
>  arch/arm/boot/dts/s3c2416-pinctrl.dtsi | 38 ++++++++++++++++++----------------
>  1 file changed, 20 insertions(+), 18 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/s3c2416-pinctrl.dtsi b/arch/arm/boot/dts/s3c2416-pinctrl.dtsi
> index 527e3193817f..6274359fb323 100644
> --- a/arch/arm/boot/dts/s3c2416-pinctrl.dtsi
> +++ b/arch/arm/boot/dts/s3c2416-pinctrl.dtsi
> @@ -8,6 +8,8 @@
>   * published by the Free Software Foundation.
>   */
>  
> +#include <dt-bindings/pinctrl/samsung.h>
> +
>  &pinctrl_0 {
>  	/*
>  	 * Pin banks
> @@ -83,91 +85,91 @@
>  
>  	uart0_data: uart0-data {
>  		samsung,pins = "gph-0", "gph-1";
> -		samsung,pin-function = <2>;
> +		samsung,pin-function = <EXYNOS_PIN_FUNC_2>;

Shouldn't macros that are also used by s3c* be named as
SAMSUNG_PIN_FUNC_2 etc. (s3c* SoCs are not Exynos)?

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics