From: David Howells <dhowells@redhat.com>
To: Jingbo Xu <jefflexu@linux.alibaba.com>
Cc: dhowells@redhat.com, xiang@kernel.org, chao@kernel.org,
jlayton@kernel.org, linux-erofs@lists.ozlabs.org,
linux-cachefs@redhat.com, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v4 1/2] fscache,cachefiles: add prepare_ondemand_read() callback
Date: Wed, 23 Nov 2022 16:44:43 +0000 [thread overview]
Message-ID: <1609247.1669221883@warthog.procyon.org.uk> (raw)
In-Reply-To: <20221117053017.21074-2-jefflexu@linux.alibaba.com>
Jingbo Xu <jefflexu@linux.alibaba.com> wrote:
> -/*
> - * Prepare a read operation, shortening it to a cached/uncached
> - * boundary as appropriate.
> - */
> -static enum netfs_io_source cachefiles_prepare_read(struct netfs_io_subrequest *subreq,
> - loff_t i_size)
> +static inline enum netfs_io_source
> +cachefiles_do_prepare_read(struct netfs_cache_resources *cres,
> + loff_t start, size_t *_len, loff_t i_size,
> + unsigned long *_flags)
That's not exactly what I meant, but I guess it would work as the compiler
would probably inline it into both callers.
> - __entry->netfs_inode, __entry->cache_inode)
> + __entry->cache_inode)
Can you not lose the netfs_inode number from the tracepoint, please? Feel
free to display 0 there for your purposes.
David
next prev parent reply other threads:[~2022-11-23 16:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 5:30 [PATCH v4 0/2] fscache,cachefiles: add prepare_ondemand_read() interface Jingbo Xu
2022-11-17 5:30 ` [PATCH v4 1/2] fscache,cachefiles: add prepare_ondemand_read() callback Jingbo Xu
2022-11-17 11:05 ` Jeff Layton
2022-11-23 3:29 ` [Linux-cachefs] [PATCH v4 1/2] fscache, cachefiles: " Jingbo Xu
2022-11-23 16:44 ` David Howells [this message]
2022-11-24 3:19 ` [PATCH v4 1/2] fscache,cachefiles: " Jingbo Xu
2022-11-17 5:30 ` [PATCH v4 2/2] erofs: switch to prepare_ondemand_read() in fscache mode Jingbo Xu
2022-11-19 0:42 ` Gao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1609247.1669221883@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=chao@kernel.org \
--cc=jefflexu@linux.alibaba.com \
--cc=jlayton@kernel.org \
--cc=linux-cachefs@redhat.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xiang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox