From: Jeff LaBundy <jeff@labundy.com>
To: lee.jones@linaro.org
Cc: linux-kernel@vger.kernel.org, Jeff LaBundy <jeff@labundy.com>
Subject: [PATCH v2 4/6] mfd: iqs62x: Increase interrupt handler return delay
Date: Sun, 17 Jan 2021 21:57:06 -0600 [thread overview]
Message-ID: <1610942228-7275-5-git-send-email-jeff@labundy.com> (raw)
In-Reply-To: <1610942228-7275-1-git-send-email-jeff@labundy.com>
The time the device takes to deassert its RDY output following an
I2C stop condition scales with the core clock frequency.
To prevent level-triggered interrupts from being reasserted after
the interrupt handler returns, increase the time before returning
to account for the worst-case delay (~90 us) plus margin.
Signed-off-by: Jeff LaBundy <jeff@labundy.com>
Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
---
Changes in v2:
- Added Acked-for-MFD-by trailer
drivers/mfd/iqs62x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/iqs62x.c b/drivers/mfd/iqs62x.c
index 7a1ff7c..07c9725 100644
--- a/drivers/mfd/iqs62x.c
+++ b/drivers/mfd/iqs62x.c
@@ -533,7 +533,7 @@ static irqreturn_t iqs62x_irq(int irq, void *context)
* ensure the device's RDY output has been deasserted by the time the
* interrupt handler returns.
*/
- usleep_range(50, 100);
+ usleep_range(150, 200);
return IRQ_HANDLED;
}
--
2.7.4
next prev parent reply other threads:[~2021-01-18 3:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-18 3:57 [PATCH v2 0/6] mfd: iqs62x: Minor cosmetic and functional improvements Jeff LaBundy
2021-01-18 3:57 ` [PATCH v2 1/6] mfd: iqs62x: Remove superfluous whitespace above fallthroughs Jeff LaBundy
2021-01-20 8:41 ` Lee Jones
2021-01-18 3:57 ` [PATCH v2 2/6] mfd: iqs62x: Remove unused bit mask Jeff LaBundy
2021-01-20 8:42 ` Lee Jones
2021-01-18 3:57 ` [PATCH v2 3/6] mfd: iqs62x: Rename regmap_config struct Jeff LaBundy
2021-01-20 8:43 ` Lee Jones
2021-01-18 3:57 ` Jeff LaBundy [this message]
2021-01-20 8:43 ` [PATCH v2 4/6] mfd: iqs62x: Increase interrupt handler return delay Lee Jones
2021-01-18 3:57 ` [PATCH v2 5/6] mfd: iqs62x: Do not poll during ATI Jeff LaBundy
2021-01-20 8:43 ` Lee Jones
2021-01-18 3:57 ` [PATCH v2 6/6] mfd: iqs62x: Do not change clock frequency " Jeff LaBundy
2021-01-20 8:48 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1610942228-7275-5-git-send-email-jeff@labundy.com \
--to=jeff@labundy.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox