From: Can Guo <cang@codeaurora.org>
To: jaegeuk@kernel.org, bvanassche@acm.org, asutoshd@codeaurora.org,
nguyenb@codeaurora.org, hongwus@codeaurora.org,
linux-scsi@vger.kernel.org, kernel-team@android.com,
cang@codeaurora.org
Cc: Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Stanley Chu <stanley.chu@mediatek.com>,
Bean Huo <beanhuo@micron.com>,
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH v3 1/3] scsi: ufs: Fix task management request completion timeout
Date: Wed, 27 Jan 2021 20:16:02 -0800 [thread overview]
Message-ID: <1611807365-35513-2-git-send-email-cang@codeaurora.org> (raw)
In-Reply-To: <1611807365-35513-1-git-send-email-cang@codeaurora.org>
ufshcd_tmc_handler() calls blk_mq_tagset_busy_iter(fn = ufshcd_compl_tm()),
but since blk_mq_tagset_busy_iter() only iterates over all reserved tags
and requests which are not in IDLE state, ufshcd_compl_tm() never gets a
chance to run. Thus, TMR always ends up with completion timeout. Fix it by
calling blk_mq_start_request() in __ufshcd_issue_tm_cmd().
Fixes: 69a6c269c097 ("scsi: ufs: Use blk_{get,put}_request() to allocate and free TMFs")
Signed-off-by: Can Guo <cang@codeaurora.org>
---
drivers/scsi/ufs/ufshcd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 8da75e6..c0c5925 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -6395,6 +6395,7 @@ static int __ufshcd_issue_tm_cmd(struct ufs_hba *hba,
spin_lock_irqsave(host->host_lock, flags);
task_tag = hba->nutrs + free_slot;
+ blk_mq_start_request(req);
treq->req_header.dword_0 |= cpu_to_be32(task_tag);
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
next parent reply other threads:[~2021-01-28 4:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1611807365-35513-1-git-send-email-cang@codeaurora.org>
2021-01-28 4:16 ` Can Guo [this message]
2021-01-29 3:22 ` [PATCH v3 1/3] scsi: ufs: Fix task management request completion timeout Bart Van Assche
2021-01-29 5:46 ` Can Guo
2021-01-28 4:16 ` [PATCH v3 2/3] scsi: ufs: Fix a race condition btw task management request send and compl Can Guo
2021-01-29 3:20 ` Bart Van Assche
2021-01-29 6:06 ` Can Guo
2021-01-29 6:29 ` Can Guo
2021-02-01 2:27 ` Bart Van Assche
2021-01-28 4:16 ` [PATCH v3 3/3] scsi: ufs: Fix wrong Task Tag used in task management request UPIUs Can Guo
2021-01-29 3:15 ` Bart Van Assche
2021-01-29 5:57 ` Can Guo
2021-02-01 2:39 ` Bart Van Assche
2021-02-05 6:09 ` Can Guo
2021-02-07 2:50 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1611807365-35513-2-git-send-email-cang@codeaurora.org \
--to=cang@codeaurora.org \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=hongwus@codeaurora.org \
--cc=jaegeuk@kernel.org \
--cc=jejb@linux.ibm.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=nguyenb@codeaurora.org \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox