From: Yong Wu <yong.wu@mediatek.com>
To: Douglas Anderson <dianders@chromium.org>
Cc: Will Deacon <will@kernel.org>, <joro@8bytes.org>,
Robin Murphy <robin.murphy@arm.com>,
<iommu@lists.linux-foundation.org>,
<linux-kernel@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH] iommu: Properly pass gfp_t in _iommu_map() to avoid atomic sleeping
Date: Tue, 2 Feb 2021 09:30:49 +0800 [thread overview]
Message-ID: <1612229449.2524.2.camel@mhfsdcap03> (raw)
In-Reply-To: <20210201170611.1.I64a7b62579287d668d7c89e105dcedf45d641063@changeid>
On Mon, 2021-02-01 at 17:06 -0800, Douglas Anderson wrote:
> Sleeping while atomic = bad. Let's fix an obvious typo to try to avoid it.
>
> The warning that was seen (on a downstream kernel with the problematic
> patch backported):
>
> BUG: sleeping function called from invalid context at mm/page_alloc.c:4726
> in_atomic(): 1, irqs_disabled(): 0, non_block: 0, pid: 9, name: ksoftirqd/0
> CPU: 0 PID: 9 Comm: ksoftirqd/0 Not tainted 5.4.93-12508-gc10c93e28e39 #1
> Call trace:
> dump_backtrace+0x0/0x154
> show_stack+0x20/0x2c
> dump_stack+0xa0/0xfc
> ___might_sleep+0x11c/0x12c
> __might_sleep+0x50/0x84
> __alloc_pages_nodemask+0xf8/0x2bc
> __arm_lpae_alloc_pages+0x48/0x1b4
> __arm_lpae_map+0x124/0x274
> __arm_lpae_map+0x1cc/0x274
> arm_lpae_map+0x140/0x170
> arm_smmu_map+0x78/0xbc
> __iommu_map+0xd4/0x210
> _iommu_map+0x4c/0x84
> iommu_map_atomic+0x44/0x58
> __iommu_dma_map+0x8c/0xc4
> iommu_dma_map_page+0xac/0xf0
>
> Fixes: d8c1df02ac7f ("iommu: Move iotlb_sync_map out from __iommu_map")
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
oh. This is my fault. Thanks for the fix.
Reviewed-by: Yong Wu <yong.wu@mediatek.com>
> ---
> I haven't done any serious testing on this. I saw a report of the
> warning and the fix seemed obvious so I'm shooting it out.
>
> drivers/iommu/iommu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
> index 3d099a31ddca..2b06b01850d5 100644
> --- a/drivers/iommu/iommu.c
> +++ b/drivers/iommu/iommu.c
> @@ -2441,7 +2441,7 @@ static int _iommu_map(struct iommu_domain *domain, unsigned long iova,
> const struct iommu_ops *ops = domain->ops;
> int ret;
>
> - ret = __iommu_map(domain, iova, paddr, size, prot, GFP_KERNEL);
> + ret = __iommu_map(domain, iova, paddr, size, prot, gfp);
> if (ret == 0 && ops->iotlb_sync_map)
> ops->iotlb_sync_map(domain, iova, size);
>
next prev parent reply other threads:[~2021-02-02 1:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 1:06 [PATCH] iommu: Properly pass gfp_t in _iommu_map() to avoid atomic sleeping Douglas Anderson
2021-02-02 1:30 ` Yong Wu [this message]
2021-02-02 13:52 ` Will Deacon
2021-02-02 13:58 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1612229449.2524.2.camel@mhfsdcap03 \
--to=yong.wu@mediatek.com \
--cc=dianders@chromium.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox