Re: [PATCH] net: hns3: avoid -Wpointer-bool-conversion warning

Nathan Chancellor
2021-02-04T21:24:09Z

On Thu, Feb 04, 2021 at 04:38:06PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> clang points out a redundant sanity check:
>
> drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c:497:28: error: address of array 'filp->f_path.dentry->d_iname' will always evaluate to 'true' [-Werror,-Wpointer-bool-conversion]
>
> This can never fail, so just remove the check.
>
> Fixes: 04987ca1b9b6 ("net: hns3: add debugfs support for tm nodes, priority and qset info")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Nathan Chancellor <nathan@kernel.org>

> ---
> drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c b/drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c
> index 6978304f1ac5..c5958754f939 100644
> --- a/drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c
> +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c
> @@ -494,9 +494,6 @@ static ssize_t hns3_dbg_read(struct file *filp, char __user *buffer,
> ssize_t size = 0;
> int ret = 0;
>
> - if (!filp->f_path.dentry->d_iname)
> - return -EINVAL;
> -
> read_buf = kzalloc(HNS3_DBG_READ_LEN, GFP_KERNEL);
> if (!read_buf)
> return -ENOMEM;
> --
> 2.29.2
>