Re: [PATCH for-next 00/32] spin lock usage optimization for SCSI drivers

tanxiaofei
2021-02-09T02:02:12Z

Hi Finn,
Thanks for reviewing the patch set.

On 2021/2/8 15:57, Finn Thain wrote:
> On Sun, 7 Feb 2021, Xiaofei Tan wrote:
>
>> Replace spin_lock_irqsave with spin_lock in hard IRQ of SCSI drivers.
>> There are no function changes, but may speed up if interrupt happen too
>> often.
>
> This change doesn't necessarily work on platforms that support nested
> interrupts.
>

Linux doesn't support nested interrupts anymore after the following
patch, so please don't worry this.

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e58aa3d2d0cc

> Were you able to measure any benefit from this change on some other
> platform?
>

It's hard to measure the benefit of this change. Hmm, you could take
this patch set as cleanup. thanks.

> Please see also,
> https://lore.kernel.org/linux-scsi/89c5cb05cb844939ae684db0077f675f@h3c.com/
>
> .
>