From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752834AbaEURPz (ORCPT ); Wed, 21 May 2014 13:15:55 -0400 Received: from gloria.sntech.de ([95.129.55.99]:44320 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752605AbaEURPw convert rfc822-to-8bit (ORCPT ); Wed, 21 May 2014 13:15:52 -0400 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: =?ISO-8859-1?Q?S=F6ren?= Brinkmann Cc: Matthias Brugger , linux-kernel@vger.kernel.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, rdunlap@infradead.org, linux@arm.linux.org.uk, daniel.lezcano@linaro.org, tglx@linutronix.de, thierry.reding@gmail.com, florian.vaussard@epfl.ch, jic23@kernel.org, jason@lakedaemon.net, andrew@lunn.ch, silvio.fricke@gmail.com, olof@lixom.net, sebastian.hesselbarth@gmail.com, sboyd@codeaurora.org, gregory.clement@free-electrons.com, arnd@arndb.de, robherring2@gmail.com, marc.zyngier@arm.com, maxime.ripard@free-electrons.com, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v5 2/6] dt-bindings: add mtk-timer bindings Date: Wed, 21 May 2014 19:18:59 +0200 Message-ID: <1615424.OJcNQb1ONt@phil> User-Agent: KMail/4.11.5 (Linux/3.13-1-amd64; KDE/4.11.3; x86_64; ; ) In-Reply-To: <3a9b6824-e088-4774-b125-7a33b5a895dc@BN1AFFO11FD022.protection.gbl> References: <1400689583-21119-1-git-send-email-matthias.bgg@gmail.com> <1948139.7c1AZ80ZQt@phil> <3a9b6824-e088-4774-b125-7a33b5a895dc@BN1AFFO11FD022.protection.gbl> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="iso-8859-1" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Mittwoch, 21. Mai 2014, 09:53:57 schrieb Sören Brinkmann: > On Wed, 2014-05-21 at 06:54PM +0200, Heiko Stübner wrote: > > Am Mittwoch, 21. Mai 2014, 09:34:10 schrieb Sören Brinkmann: > > > Hi Matthias, > > > > > > On Wed, 2014-05-21 at 06:26PM +0200, Matthias Brugger wrote: > > > > + compatible = "mediatek,mtk6577-timer"; > > > > + reg = <0x10008000 0x80>; > > > > + interrupts = ; > > > > + clocks = <&system_clk>, <&rtc_clk>; > > > > + clock-names = "system-clk", "rtc-clk"; > > > > > > I'm still not convinced that the timer IP calls its clock inputs this > > > way, but well. > > > > Maybe this might convince you ;-) > > > > "The GPT includes 5 32-bit timers and one 64-bit timer. Each timer has 4 > > operation modes, which are ONE-SHOT, REPEAT, KEEP-GO and FREERUN, and > > can operate on one of the 2 clock sources, RTC clock (32.768kHz) and > > system clock (13MHz)." > > Is this copied from the timer data sheet or the SOC documentation? That is from the processor datasheet containing the timer documentation. I don't think it's customary for soc vendors to provide additional individual documentation for self-developed IPs contained in a SoC.