From: Rob Herring <robh@kernel.org>
To: Hermes Zhang <chenhui.zhang@axis.com>
Cc: Pavel Machek <pavel@ucw.cz>, Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, kernel@axis.com,
linux-kernel@vger.kernel.org, Dan Murphy <dmurphy@ti.com>,
Hermes Zhang <chenhuiz@axis.com>,
linux-leds@vger.kernel.org
Subject: Re: [PATCH v2] dt-binding: leds: Document leds-multi-gpio bindings
Date: Mon, 22 Mar 2021 11:38:18 -0600 [thread overview]
Message-ID: <1616434698.344402.2887754.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <20210322091819.29119-1-chenhui.zhang@axis.com>
On Mon, 22 Mar 2021 17:18:19 +0800, Hermes Zhang wrote:
> From: Hermes Zhang <chenhuiz@axis.com>
>
> Document the device tree bindings of the multiple GPIOs LED driver
> Documentation/devicetree/bindings/leds/leds-multi-gpio.yaml.
>
> Signed-off-by: Hermes Zhang <chenhuiz@axis.com>
> ---
>
> Notes:
> Fix typo and missing item
>
> .../bindings/leds/leds-multi-gpio.yaml | 49 +++++++++++++++++++
> 1 file changed, 49 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/leds/leds-multi-gpio.yaml
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/leds/leds-multi-gpio.example.dt.yaml: gpios-led: led-states: 'oneOf' conditional failed, one must be fixed:
[[0, 1, 2, 3]] is too short
[0, 1, 2, 3] is too long
From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/leds/leds-multi-gpio.yaml
See https://patchwork.ozlabs.org/patch/1456433
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
next prev parent reply other threads:[~2021-03-22 17:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-22 9:18 [PATCH v2] dt-binding: leds: Document leds-multi-gpio bindings Hermes Zhang
2021-03-22 17:38 ` Rob Herring [this message]
2021-03-23 4:27 ` Hermes Zhang
2021-03-23 14:00 ` Rob Herring
2021-03-24 2:52 ` Hermes Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1616434698.344402.2887754.nullmailer@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=chenhui.zhang@axis.com \
--cc=chenhuiz@axis.com \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=kernel@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox