From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: daniel.lezcano@linaro.org, lenb@kernel.org,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-samsung-soc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
kyungmin.park@samsung.com
Subject: Re: [PATCH v2 0/9] cpuidle: rework device state count handling
Date: Mon, 13 Jan 2014 22:20:27 +0100 [thread overview]
Message-ID: <1616617.RcagPEYAid@vostro.rjw.lan> (raw)
In-Reply-To: <2079155.EyEBRDoJjP@vostro.rjw.lan>
On Saturday, January 11, 2014 01:37:29 AM Rafael J. Wysocki wrote:
> On Friday, December 20, 2013 07:47:22 PM Bartlomiej Zolnierkiewicz wrote:
> > Hi,
> >
> > Some cpuidle drivers assume that cpuidle core will handle cases where
> > device->state_count is smaller than driver->state_count, unfortunately
> > currently this is untrue (device->state_count is used only for handling
> > cpuidle state sysfs entries and driver->state_count is used for all
> > other cases) and will not be fixed in the future as device->state_count
> > is planned to be removed [1].
> >
> > This patchset fixes such drivers (ARM EXYNOS cpuidle driver and ACPI
> > cpuidle driver), removes superflous device->state_count initialization
> > from drivers for which device->state_count equals driver->state_count
> > (POWERPC pseries cpuidle driver and intel_idle driver) and finally
> > removes state_count field from struct cpuidle_device.
> >
> > Additionaly (while at it) this patchset fixes C1E promotion disable
> > quirk handling (in intel_idle driver) and converts cpuidle drivers code
> > to use the common cpuidle_[un]register() routines (in POWERPC pseries
> > cpuidle driver and intel_idle driver).
> >
> > [1] http://permalink.gmane.org/gmane.linux.power-management.general/36908
> >
> > Reference to v1:
> > http://comments.gmane.org/gmane.linux.power-management.general/37390
> >
> > Changes since v1:
> > - synced patch series with next-20131220
> > - added ACKs from Daniel Lezcano
>
> This series breaks boot on one of my test machines with intel_idle, so I'm
> not sure how well it has been tested.
>
> I've dropped it entirely for now. If I have the time, I will try to identify
> the root cause of the failure, but that may not happen before the merge window.
> Sorry about that.
The breakage was introduced by patch [8/9], so I've re-applied patches [1-7/9]
from this series. Please refer to Fengguang's report [1] for the breakage
details.
Thanks!
[1] http://marc.info/?l=linux-kernel&m=138964167909907&w=2
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
prev parent reply other threads:[~2014-01-13 21:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-20 18:47 [PATCH v2 0/9] cpuidle: rework device state count handling Bartlomiej Zolnierkiewicz
2013-12-20 18:47 ` [PATCH v2 1/9] ARM: EXYNOS: cpuidle: fix AFTR mode check Bartlomiej Zolnierkiewicz
2013-12-20 20:47 ` Kukjin Kim
2013-12-20 21:16 ` Daniel Lezcano
2013-12-20 18:47 ` [PATCH v2 2/9] POWERPC: pseries: cpuidle: remove superfluous dev->state_count initialization Bartlomiej Zolnierkiewicz
2014-01-02 5:41 ` Deepthi Dharwar
2013-12-20 18:47 ` [PATCH v2 3/9] POWERPC: pseries: cpuidle: use the common cpuidle_[un]register() routines Bartlomiej Zolnierkiewicz
2014-01-02 5:42 ` Deepthi Dharwar
2013-12-20 18:47 ` [PATCH v2 4/9] ACPI / cpuidle: fix max idle state handling with hotplug CPU support Bartlomiej Zolnierkiewicz
2013-12-20 18:47 ` [PATCH v2 5/9] ACPI / cpuidle: remove dev->state_count setting Bartlomiej Zolnierkiewicz
2013-12-20 18:47 ` [PATCH v2 6/9] intel_idle: do C1E promotion disable quirk for hotplugged CPUs Bartlomiej Zolnierkiewicz
2013-12-20 21:52 ` Daniel Lezcano
2013-12-20 18:47 ` [PATCH v2 7/9] intel_idle: remove superfluous dev->state_count initialization Bartlomiej Zolnierkiewicz
2013-12-20 21:48 ` Daniel Lezcano
2013-12-20 18:47 ` [PATCH v2 8/9] intel_idle: use the common cpuidle_[un]register() routines Bartlomiej Zolnierkiewicz
2013-12-20 21:42 ` Daniel Lezcano
2013-12-20 18:47 ` [PATCH v2 9/9] cpuidle: remove state_count field from struct cpuidle_device Bartlomiej Zolnierkiewicz
2013-12-20 21:27 ` Daniel Lezcano
2014-01-06 12:12 ` [PATCH v2 0/9] cpuidle: rework device state count handling Rafael J. Wysocki
2014-01-11 0:37 ` Rafael J. Wysocki
2014-01-13 21:20 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1616617.RcagPEYAid@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=b.zolnierkie@samsung.com \
--cc=daniel.lezcano@linaro.org \
--cc=kyungmin.park@samsung.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox