* [PATCH net-next v2] net: dsa: hellcreek: Remove redundant dev_err call in hellcreek_probe()
@ 2021-03-27 10:07 Huang Guobin
2021-03-29 1:10 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Huang Guobin @ 2021-03-27 10:07 UTC (permalink / raw)
To: huangguobin4, Kurt Kanzenbach, Andrew Lunn, Vivien Didelot,
Florian Fainelli, David S. Miller, Jakub Kicinski
Cc: netdev, linux-kernel
From: Guobin Huang <huangguobin4@huawei.com>
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Guobin Huang <huangguobin4@huawei.com>
---
drivers/net/dsa/hirschmann/hellcreek.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/net/dsa/hirschmann/hellcreek.c b/drivers/net/dsa/hirschmann/hellcreek.c
index 918be7eb626f..4d78219da253 100644
--- a/drivers/net/dsa/hirschmann/hellcreek.c
+++ b/drivers/net/dsa/hirschmann/hellcreek.c
@@ -1842,10 +1842,8 @@ static int hellcreek_probe(struct platform_device *pdev)
}
hellcreek->base = devm_ioremap_resource(dev, res);
- if (IS_ERR(hellcreek->base)) {
- dev_err(dev, "No memory available!\n");
+ if (IS_ERR(hellcreek->base))
return PTR_ERR(hellcreek->base);
- }
res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "ptp");
if (!res) {
@@ -1854,10 +1852,8 @@ static int hellcreek_probe(struct platform_device *pdev)
}
hellcreek->ptp_base = devm_ioremap_resource(dev, res);
- if (IS_ERR(hellcreek->ptp_base)) {
- dev_err(dev, "No memory available!\n");
+ if (IS_ERR(hellcreek->ptp_base))
return PTR_ERR(hellcreek->ptp_base);
- }
ret = hellcreek_detect(hellcreek);
if (ret) {
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next v2] net: dsa: hellcreek: Remove redundant dev_err call in hellcreek_probe()
2021-03-27 10:07 [PATCH net-next v2] net: dsa: hellcreek: Remove redundant dev_err call in hellcreek_probe() Huang Guobin
@ 2021-03-29 1:10 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-03-29 1:10 UTC (permalink / raw)
To: Huang Guobin
Cc: kurt, andrew, vivien.didelot, f.fainelli, davem, kuba, netdev,
linux-kernel
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Sat, 27 Mar 2021 18:07:18 +0800 you wrote:
> From: Guobin Huang <huangguobin4@huawei.com>
>
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Guobin Huang <huangguobin4@huawei.com>
>
> [...]
Here is the summary with links:
- [net-next,v2] net: dsa: hellcreek: Remove redundant dev_err call in hellcreek_probe()
https://git.kernel.org/netdev/net-next/c/656151aaa623
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-29 1:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-27 10:07 [PATCH net-next v2] net: dsa: hellcreek: Remove redundant dev_err call in hellcreek_probe() Huang Guobin
2021-03-29 1:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox