* [PATCH net-next v2] net: mdio: Remove redundant dev_err call in mdio_mux_iproc_probe()
@ 2021-03-29 1:38 Huang Guobin
2021-03-29 20:20 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Huang Guobin @ 2021-03-29 1:38 UTC (permalink / raw)
To: huangguobin4, David S. Miller, Jakub Kicinski, Ray Jui,
Scott Branden, bcm-kernel-feedback-list
Cc: netdev, linux-arm-kernel, linux-kernel
From: Guobin Huang <huangguobin4@huawei.com>
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Guobin Huang <huangguobin4@huawei.com>
---
drivers/net/mdio/mdio-mux-bcm-iproc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/mdio/mdio-mux-bcm-iproc.c b/drivers/net/mdio/mdio-mux-bcm-iproc.c
index 641cfa41f492..03261e6b9ceb 100644
--- a/drivers/net/mdio/mdio-mux-bcm-iproc.c
+++ b/drivers/net/mdio/mdio-mux-bcm-iproc.c
@@ -197,10 +197,8 @@ static int mdio_mux_iproc_probe(struct platform_device *pdev)
res->end = res->start + MDIO_REG_ADDR_SPACE_SIZE - 1;
}
md->base = devm_ioremap_resource(&pdev->dev, res);
- if (IS_ERR(md->base)) {
- dev_err(&pdev->dev, "failed to ioremap register\n");
+ if (IS_ERR(md->base))
return PTR_ERR(md->base);
- }
md->mii_bus = devm_mdiobus_alloc(&pdev->dev);
if (!md->mii_bus) {
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net-next v2] net: mdio: Remove redundant dev_err call in mdio_mux_iproc_probe()
2021-03-29 1:38 [PATCH net-next v2] net: mdio: Remove redundant dev_err call in mdio_mux_iproc_probe() Huang Guobin
@ 2021-03-29 20:20 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-03-29 20:20 UTC (permalink / raw)
To: Huang Guobin
Cc: davem, kuba, rjui, sbranden, bcm-kernel-feedback-list, netdev,
linux-arm-kernel, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Mon, 29 Mar 2021 09:38:32 +0800 you wrote:
> From: Guobin Huang <huangguobin4@huawei.com>
>
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Guobin Huang <huangguobin4@huawei.com>
>
> [...]
Here is the summary with links:
- [net-next,v2] net: mdio: Remove redundant dev_err call in mdio_mux_iproc_probe()
https://git.kernel.org/netdev/net-next/c/6be836818872
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-29 20:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-29 1:38 [PATCH net-next v2] net: mdio: Remove redundant dev_err call in mdio_mux_iproc_probe() Huang Guobin
2021-03-29 20:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox