From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757379AbcGJWT0 (ORCPT ); Sun, 10 Jul 2016 18:19:26 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:57519 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757207AbcGJWTX (ORCPT ); Sun, 10 Jul 2016 18:19:23 -0400 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Wan Zongshun , Russell King , devicetree@vger.kernel.org, linux-clk@vger.kernel.org, jason@lakedaemon.net, Daniel Lezcano , linux-kernel@vger.kernel.org, p.zabel@pengutronix.de, Thomas Gleixner , Wan Zongshun Subject: Re: [PATCH v2 09/10] Documentation: devicetree: Add dts description for nuc900 Date: Mon, 11 Jul 2016 00:22:09 +0200 Message-ID: <1618088.N8H7ez3XRZ@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1468136542-2656-2-git-send-email-vw@iommu.org> References: <1468136542-2656-1-git-send-email-vw@iommu.org> <1468136542-2656-2-git-send-email-vw@iommu.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:8Gve0AtrJQqjwgx5g5k+rybgcKBVln+o/d02N67Ko0Nodk104JQ f72uHK61UZilEaASy9jw/eaFmEpbezX7x5NpuJI6EtoJI2mkkAC587Mlb5WPMfESiVjVn5R JbVcEDfi3ORW2nQbW4G71NaZ6r4c4zRuFptpoxrhiSSuboLEaTd7NgWFW0PcSqdJ/x6Ugjg nbZNgfHDEFktEI9mlfD+w== X-UI-Out-Filterresults: notjunk:1;V01:K0:BHKB4d1QLFU=:0Za0Y2p22EJ04RCwM5z/TR DM3y/AmCXBw0S45ObPGpKxt5xLu//it2YI7ABYZ/HZZWfkYfey5+NXDWo2qvju8ft0ddlyqwK EXtrsRyquqaqv0FrJYqlFvIv2GuCeTvAlZpvupzSrJpNSTVMfphjav/gJMnJuaBAT3X141qlu gLrdL6yip2M92I63mxVK1j20eW6sBS4pOP/34X/nkALR0/n2Tazph3uF5+4U/Rp5WQ+IN0PJu KM71S/97F4BoDOjFOI9MpqaqDEgNVH6wZao/Wm++I1vOomB8knQxuXqVZ/AZA9AcXodYKdDrV cfE4IC1S+w00fJJZ+5PkFtJxZiG3zgFocBZMNir5fCuQFTZ3q9Sry56AhLy8Wo+/LB1VWrYgQ UglLrUpzI4saDklfhmkbbbv23DQd4byfnK/yk7M1jtpdjkjIMQ08fVFmKoy3qfuo2T2YmAvVn Zy4CAjac1EV3+Df21uP8GyEPMFn1d6Irmf01vnMPfH1WcXEiKYhYMf9WYdSaLK6mxbE5Pjp2K R5q/ji91yOckBhaIYJfn0EHR3xnmbZ+ju1iXjhW2Ox7q2XhFL2a+blO26jhYHgLKnIY8sXpdW qWLfFm4jPyqfm2GtdPXs+TJMsBgKYwWDB2FN7m5gZREOGo4ISK0ZC9YPzpVHQ2NuXq0oX7v7b hqpcm9uQsVUNi/36tIHtOhLazt1+j6mr3ehwGKaC08XAdEPSXJaK2/vivtk71aVM0G2EoqfXy Y050ObD7hUzHtYdz Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sunday, July 10, 2016 3:42:21 PM CEST Wan Zongshun wrote: > diff --git a/Documentation/devicetree/bindings/soc/nuvoton/nuvoton,nuc900-soc.txt b/Documentation/devicetree/bindings/soc/nuvoton/nuvoton,nuc900-soc.txt > new file mode 100644 > index 0000000..0284edf > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/nuvoton/nuvoton,nuc900-soc.txt > @@ -0,0 +1,12 @@ > +. Nuvoton NUC900 series, Soc specific driver binding. > + > +Required properties: > +- compatible : Should be "nuvoton,nuc900-soc" > +- syscon : Reference to gcr controller. > + > +Example: > + > +reset { > + compatible = "nuvoton,nuc900-soc"; > + syscon = <&gcr>; > +}; I think this one should be dropped: Instead of modeling the DT based on what is convenient for the current Linux driver implementation, we only want to list devices in the dts that are physically present, and the "soc" is really the sum of all the on-chip devices. Better change the soc_device driver to bind directly to the "nuvoton,nuc970-gcr" device. Arnd