[PATCH] clocksource/drivers/sprd: Remove the dependency between sprd timer and SPRD arch

[PATCH] clocksource/drivers/sprd: Remove the dependency between sprd timer and SPRD arch

[Nianfu Bai]

From: Nianfu Bai <nianfu.bai@unisoc.com>

Tick broadcast installed by insmod cannot switch to oneshot mode correctly
caused by linux timer framework, need to build in kernel image. SPRD_TIMER
has been selected by SPRD arch, we have to enable SPRD arch when we build
sprd timer in kernel image, this action conflicts with general kernel image,
so we need to remove the dependency between sprd timer and SPRD arch.

Signed-off-by: Nianfu Bai <nianfu.bai@unisoc.com>
Signed-off-by: Ruifeng Zhang <ruifeng.zhang1@unisoc.com>
---
 drivers/clocksource/Kconfig | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index 39aa21d..04b333c 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -447,10 +447,8 @@ config MTK_TIMER
 	  Support for Mediatek timer driver.
 
 config SPRD_TIMER
-	bool "Spreadtrum timer driver" if EXPERT
+	bool "Spreadtrum timer driver" if COMPILE_TEST
 	depends on HAS_IOMEM
-	depends on (ARCH_SPRD || COMPILE_TEST)
-	default ARCH_SPRD
 	select TIMER_OF
 	help
 	  Enables support for the Spreadtrum timer driver.
-- 
1.9.1

[PATCH] clocksource/drivers/sprd: Remove the dependency between sprd timer and SPRD arch

[Nianfu Bai]

From: Nianfu Bai <nianfu.bai@unisoc.com>

Tick broadcast installed by insmod cannot switch to oneshot mode correctly
caused by linux timer framework, need to build in kernel image. SPRD_TIMER
has been selected by SPRD arch, we have to enable SPRD arch when we build
sprd timer in kernel image, this action conflicts with general kernel image,
so we need to remove the dependency between sprd timer and SPRD arch.

Signed-off-by: Nianfu Bai <nianfu.bai@unisoc.com>
Signed-off-by: Ruifeng Zhang <ruifeng.zhang1@unisoc.com>
---
 drivers/clocksource/Kconfig | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index 39aa21d..04b333c 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -447,10 +447,8 @@ config MTK_TIMER
 	  Support for Mediatek timer driver.
 
 config SPRD_TIMER
-	bool "Spreadtrum timer driver" if EXPERT
+	bool "Spreadtrum timer driver" if COMPILE_TEST
 	depends on HAS_IOMEM
-	depends on (ARCH_SPRD || COMPILE_TEST)
-	default ARCH_SPRD
 	select TIMER_OF
 	help
 	  Enables support for the Spreadtrum timer driver.
-- 
1.9.1

Re: [PATCH] clocksource/drivers/sprd: Remove the dependency between sprd timer and SPRD arch

[Greg KH]

On Tue, May 11, 2021 at 03:08:45PM +0800, Nianfu Bai wrote:
> From: Nianfu Bai <nianfu.bai@unisoc.com>
> 
> Tick broadcast installed by insmod cannot switch to oneshot mode correctly
> caused by linux timer framework, need to build in kernel image. SPRD_TIMER
> has been selected by SPRD arch, we have to enable SPRD arch when we build
> sprd timer in kernel image, this action conflicts with general kernel image,
> so we need to remove the dependency between sprd timer and SPRD arch.

This wording is a bit rough to parse.

All you really want to do is take away the fact that ARCH_SPRD is
required here to turn this off, right?

> 
> Signed-off-by: Nianfu Bai <nianfu.bai@unisoc.com>
> Signed-off-by: Ruifeng Zhang <ruifeng.zhang1@unisoc.com>
> ---
>  drivers/clocksource/Kconfig | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> index 39aa21d..04b333c 100644
> --- a/drivers/clocksource/Kconfig
> +++ b/drivers/clocksource/Kconfig
> @@ -447,10 +447,8 @@ config MTK_TIMER
>  	  Support for Mediatek timer driver.
>  
>  config SPRD_TIMER
> -	bool "Spreadtrum timer driver" if EXPERT
> +	bool "Spreadtrum timer driver" if COMPILE_TEST

No need for "if COMPILE_TEST" on this line.

>  	depends on HAS_IOMEM
> -	depends on (ARCH_SPRD || COMPILE_TEST)
> -	default ARCH_SPRD

Just drop the ARCH_SPRD portion here and maybe make it depend on ARM64
instead like:
	depends on (ARM64 || COMPILE_TEST)

and drop the EXPERT check above?

What is the goal of what you want to do here?  Just allow this to be
enabled on what type of systems?

thanks,

greg k-h

Re: [PATCH] clocksource/drivers/sprd: Remove the dependency between sprd timer and SPRD arch

[Daniel Lezcano]

On 11/05/2021 09:08, Nianfu Bai wrote:
> From: Nianfu Bai <nianfu.bai@unisoc.com>
> 
> Tick broadcast installed by insmod cannot switch to oneshot mode correctly
> caused by linux timer framework, need to build in kernel image.

What timer is compiled as a module? Why the timer framework does not
allow to switch to it ?

> SPRD_TIMER
> has been selected by SPRD arch, we have to enable SPRD arch when we build
> sprd timer in kernel image, this action conflicts with general kernel image,

Why this is conflicting with general kernel image?

> so we need to remove the dependency between sprd timer and SPRD arch.

Can you rephrase the changelog, I'm not getting the point.

> Signed-off-by: Nianfu Bai <nianfu.bai@unisoc.com>
> Signed-off-by: Ruifeng Zhang <ruifeng.zhang1@unisoc.com>
> ---
>  drivers/clocksource/Kconfig | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> index 39aa21d..04b333c 100644
> --- a/drivers/clocksource/Kconfig
> +++ b/drivers/clocksource/Kconfig
> @@ -447,10 +447,8 @@ config MTK_TIMER
>  	  Support for Mediatek timer driver.
>  
>  config SPRD_TIMER
> -	bool "Spreadtrum timer driver" if EXPERT
> +	bool "Spreadtrum timer driver" if COMPILE_TEST
>  	depends on HAS_IOMEM
> -	depends on (ARCH_SPRD || COMPILE_TEST)
> -	default ARCH_SPRD
>  	select TIMER_OF
>  	help
>  	  Enables support for the Spreadtrum timer driver.
> 


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog