From: Rob Herring <robh@kernel.org>
To: Nandor Han <nandor.han@vaisala.com>
Cc: robh+dt@kernel.org, linux-kernel@vger.kernel.org,
srinivas.kandagatla@linaro.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/4] dt-bindings: nvmem: Add bootcount-nvmem
Date: Wed, 28 Apr 2021 17:15:09 -0500 [thread overview]
Message-ID: <1619648109.794134.4061034.nullmailer@robh.at.kernel.org> (raw)
In-Reply-To: <e0f9c2629ad651817a4726cd4f2d8e1775201595.1619617498.git.nandor.han@vaisala.com>
On Wed, 28 Apr 2021 16:50:38 +0300, Nandor Han wrote:
> Documents the device tree bindings for `bootcount-nvmem` driver.
>
> Signed-off-by: Nandor Han <nandor.han@vaisala.com>
> ---
> .../bindings/nvmem/bootcount-nvmem.yaml | 66 +++++++++++++++++++
> 1 file changed, 66 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/nvmem/bootcount-nvmem.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/nvmem/bootcount-nvmem.example.dts:27.17-34: Warning (reg_format): /example-0/rtc@68/bootcount_nvmem_regs@e:reg: property has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1)
Documentation/devicetree/bindings/nvmem/bootcount-nvmem.example.dts:25.21-29.11: Warning (unit_address_vs_reg): /example-0/rtc@68: node has a unit name, but no reg or ranges property
Documentation/devicetree/bindings/nvmem/bootcount-nvmem.example.dt.yaml: Warning (pci_device_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/nvmem/bootcount-nvmem.example.dt.yaml: Warning (pci_device_bus_num): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/nvmem/bootcount-nvmem.example.dt.yaml: Warning (simple_bus_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/nvmem/bootcount-nvmem.example.dt.yaml: Warning (i2c_bus_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/nvmem/bootcount-nvmem.example.dt.yaml: Warning (spi_bus_reg): Failed prerequisite 'reg_format'
Documentation/devicetree/bindings/nvmem/bootcount-nvmem.example.dts:26.52-28.15: Warning (avoid_default_addr_size): /example-0/rtc@68/bootcount_nvmem_regs@e: Relying on default #address-cells value
Documentation/devicetree/bindings/nvmem/bootcount-nvmem.example.dts:26.52-28.15: Warning (avoid_default_addr_size): /example-0/rtc@68/bootcount_nvmem_regs@e: Relying on default #size-cells value
Documentation/devicetree/bindings/nvmem/bootcount-nvmem.example.dt.yaml: Warning (unique_unit_address): Failed prerequisite 'avoid_default_addr_size'
See https://patchwork.ozlabs.org/patch/1471179
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
next prev parent reply other threads:[~2021-04-28 22:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-28 13:50 [PATCH v2 0/4] Bootcount driver using NVMEM cell as backend Nandor Han
2021-04-28 13:50 ` [PATCH v2 1/4] dt-bindings: nvmem: Add bootcount-nvmem Nandor Han
2021-04-28 22:15 ` Rob Herring [this message]
2021-04-29 20:53 ` Rob Herring
2021-04-30 8:21 ` Nandor Han
2021-04-28 13:50 ` [PATCH v2 2/4] nvmem: bootcount: add bootcount driver Nandor Han
2021-04-28 13:50 ` [PATCH v2 3/4] nvmem: snvs_lpgpr: use cell stride for regmap size calculation Nandor Han
2021-04-28 13:50 ` [PATCH v2 4/4] nvmem: snvs_lpgpr: support two bytes NVMEM cell size Nandor Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1619648109.794134.4061034.nullmailer@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nandor.han@vaisala.com \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox